Re: [PATCH 3/5] mshtml: Keep moniker reference after start_binding call.

2013-09-18 Thread Alexandre Julliard
Jacek Caban writes: > --- > dlls/mshtml/navigate.c | 3 --- > 1 file changed, 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:3397: Test failed: mon should be destroyed here url.c:3397: Test fai

Re: [PATCH 1/5] user32: Add a SetMinMaxInfo driver entry point.

2013-09-18 Thread Ken Thomases
On Sep 16, 2013, at 1:21 PM, Ken Thomases wrote: > On Sep 16, 2013, at 12:55 PM, Alexandre Julliard wrote: > >> It's better to avoid adding entry points that don't correspond to >> Windows APIs. Instead you should request the info when you need it. > > Cocoa makes use of the size limits "spontan

Re: [PATCH 8/8] d3d9/tests: Test invalid volume lock boxes.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2234 Your paranoid andr

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2237 Your paranoid andr

Re: [PATCH 3/8] wined3d: Check for support before creating volume textures.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2232 Your paranoid andr

Re: [PATCH 1/8] d3dx9_36/tests: Create*TextureFromFileInMemory doesn't fail.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2231 Your paranoid andr

Re: [4/4] ws2_32: Do not allow socket creation if WSAStartup was not called

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2238 Your paranoid andr

Re: [PATCH 7/8] d3d9/tests: Add tests for block-based volume formats.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2233 Your paranoid andr

Re: [1/4] ws2_32: Use the struct information when the parameters are zero in WSASocket (try 2)

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2235 Your paranoid andr

Re: wsnmp32: Add stub implementations for a couple of functions.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2230 Your paranoid andr

Re: [2/4] ws2_32: Auto detect the socket type and family based on the protocol (try 2)

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2236 Your paranoid andr

Re: [4/4] ws2_32: Do not allow socket creation if WSAStartup was not called

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2229 Your paranoid andr

Re: [2/4] ws2_32: Auto detect the socket type and family based on the protocol

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2227 Your paranoid andr

Re: [1/4] ws2_32: Use the struct information when the parameters are zero in WSASocket

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2226 Your paranoid andr

Re: [3/4] ws2_32: Filter invalid socket parameters and return the appropriate error

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2228 Your paranoid andr

Re: Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Thomas Faber
On 2013-09-18 11:31, Dmitry Timoshkov wrote: > Thomas Faber wrote: >> status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, >> sizeof(contents), &offset, NULL); >> ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below >> */, "expected STATUS_PENDING, got %#x\n", stat

Re: kernel32/tests: Add initial CreateFile2 tests based on the CreateFileW tests (try 3)

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2221 Your paranoid andr

Re: msvcrt/tests: Load the correct function on ARM

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key= Your paranoid andr

Re: msvcrt: Fix Inf and NaN handling in printf function

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2217 Your paranoid andr

Re: [1/2] shlwapi/tests: Add a read/write test for IStream on files.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2214 Your paranoid andr

Re: [2/2] shlwapi: Write file access also assumes read access.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2215 Your paranoid andr

Re: [4/5] ws2_32: Fix WSASocket return code for invalid combination of socket type and protocol

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2211 Your paranoid andr

Re: [5/5] ws2_32: Fix the error returned for denied SOCK_RAW attempts

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2212 Your paranoid andr

Re: Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Dmitry Timoshkov
Thomas Faber wrote: > I noticed a couple of tests structured like this: > > status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, > sizeof(contents), &offset, NULL); > ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see > below */, "expected STATUS_PENDING, got %#x\n", s

Asynchronous read/write tests in ntdll/tests/file.c

2013-09-18 Thread Thomas Faber
Hey Dmitry, I noticed a couple of tests structured like this: status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents, sizeof(contents), &offset, NULL); ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below */, "expected STATUS_PENDING, got %#x\n", status); ok(iob.Status

Re: [1/5] ws2_32: Advertise protocol entries as default

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2210 Your paranoid andr

Re: patch:add ualapi directory

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2209 Your paranoid andr

Re: [PATCH 2/8] wined3d: Introduce a format flag for volume texture support.

2013-09-18 Thread Henri Verbeet
On 17 September 2013 21:07, Stefan Dösinger wrote: > I might have misunderstood what you meant with "separate flags for > each GL resource type". Did you mean something like this > > B8G8R8A8_UNORM.flags[texture2d] = RENDERTARGET | TEXTURE | ...; > B8G8R8A8_UNORM.flags[renderbuffer] = RENDERTARGET

Re: [8/9] gdi32: Return GDI_ERROR when requested empty glyph bitmaps.

2013-09-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2207 Your paranoid andr

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Dmitry Timoshkov
Nikolay Sivov wrote: > > --- a/dlls/ntdll/tests/file.c > > +++ b/dlls/ntdll/tests/file.c > > @@ -1985,6 +1985,22 @@ static void test_read_write(void) > > > > bytes = 0xdeadbeef; > > SetLastError(0xdeadbeef); > > +ret = ReadFile(INVALID_HANDLE_VALUE, buf, 0,&bytes, NULL); > > +todo

Re: [1/4] ntdll/tests: Add 0-length read tests for a disk file.

2013-09-18 Thread Nikolay Sivov
On 09/18/2013 10:53 AM, Dmitry Timoshkov wrote: --- dlls/ntdll/tests/file.c | 41 + 1 file changed, 41 insertions(+) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 120fdac..5ae605b 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/nt