Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Dmitry Timoshkov
Francois Gouget wrote: > > > > This VM is broken, > > > > > > How so? That is: what should I do to fix it? > > > > Investigate, find the source of failures and fix it? Note, that all > > other VMs pass this test just fine, moreover, this same w7pro64 VM > > doesn't always fail. > > You obvious

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Francois Gouget
On Thu, 26 Sep 2013, Dmitry Timoshkov wrote: [...] > > > This VM is broken, > > > > How so? That is: what should I do to fix it? > > Investigate, find the source of failures and fix it? Note, that all > other VMs pass this test just fine, moreover, this same w7pro64 VM > doesn't always fail. Yo

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Dmitry Timoshkov
Francois Gouget wrote: > > > === w7pro64 (32 bit comm) === > > > comm.c:863: Test failed: WaitCommEvent failed with a timeout > > > comm.c:875: recovering after WAIT_TIMEOUT... > > > comm.c:886: Test failed: WaitCommEvent error 0 > > > comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY,

Re: user32: Avoid using CONST.

2013-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2332 Your paranoid andr

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Francois Gouget
On Tue, 24 Sep 2013, Dmitry Timoshkov wrote: > Marvin wrote: > > > === w7pro64 (32 bit comm) === > > comm.c:863: Test failed: WaitCommEvent failed with a timeout > > comm.c:875: recovering after WAIT_TIMEOUT... > > comm.c:886: Test failed: WaitCommEvent error 0 > > comm.c:888: Test failed: WaitC

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify

2013-09-25 Thread Sebastian Lackner
Am 25.09.2013 12:19, schrieb Alexandre Julliard: > Sebastian Lackner writes: > >> --- >> dlls/winex11.drv/event.c | 99 >> +++--- >> 1 file changed, 58 insertions(+), 41 deletions(-) > > These should go in the patches that need them. Also you should sta

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Henri Verbeet
On 25 September 2013 15:32, Rico Schüller wrote: > Yes. Depending on the use case we may create it on the Begin/BeginPass when > the shader is needed the first time (this may also be something like > isParameterUsed or GetVertexShader). We don't need the shaders for cases > like GetPassDesc, where

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-25 Thread Jacek Caban
Hi Hans, Sorry for the delay, I wanted to test it a bit more before answering. On 09/23/13 10:50, Hans Leidekker wrote: > On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: >> I was hoping for a test like the attached one, which shows that there is >> still more work to do. But it's a step in

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts

2013-09-25 Thread Aric Stewart
On 9/25/13 7:09 AM, Nikolay Sivov wrote: > On 9/25/2013 16:03, Aric Stewart wrote: >> defaultContext = ImmCreateContext(); >> +if (defaultContext) >> +((InputContextData*)defaultContext)->threadDefault = TRUE; > I think a nicer way is to let ImmCreateContext() set this

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Aric Stewart
On 9/25/13 7:11 AM, Nikolay Sivov wrote: > On 9/25/2013 16:03, Aric Stewart wrote: >> +if (!thread_data->defaultContext) >> +{ >> +HIMC defaultContext; >> +LeaveCriticalSection(&threaddata_cs); >> +defaultContext = ImmCreateContext(); >> +thread_data = IMM_Ge

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Rico Schüller
On 25.09.2013 14:02, Matteo Bruni wrote: 2013/9/24 Rico Schüller : --- dlls/d3dx9_36/effect.c | 248 +++-- 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Nikolay Sivov
On 9/25/2013 16:03, Aric Stewart wrote: +if (!thread_data->defaultContext) +{ +HIMC defaultContext; +LeaveCriticalSection(&threaddata_cs); +defaultContext = ImmCreateContext(); +thread_data = IMM_GetThreadData(0); Why do you need to unlock/lock around ImmCr

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts

2013-09-25 Thread Nikolay Sivov
On 9/25/2013 16:03, Aric Stewart wrote: defaultContext = ImmCreateContext(); +if (defaultContext) +((InputContextData*)defaultContext)->threadDefault = TRUE; I think a nicer way is to let ImmCreateContext() set this attribute.

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Matteo Bruni
2013/9/24 Rico Schüller : > --- > dlls/d3dx9_36/effect.c | 248 > +++-- > 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) > I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@ static HRESULT d3dx9_parse_resource(s

Re: (try 4)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Alexandre Julliard
Aric Stewart writes: > --- > dlls/imm32/imm.c | 153 > +-- > 1 file changed, 116 insertions(+), 37 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok err

Re: Wine Gecko 2.24-beta1

2013-09-25 Thread Jacek Caban
On 08/18/13 04:14, Zhenbo Li wrote: > I've tested some websites, and found that these pages have problems: > > http://mail.163.com (it will make gecko crash) > http://huaban.com (nothing can be shown) > http://douban.com (no pictures) > http://html5test.com/ (can't

Re: crypt32: Support HCCE_LOCAL_MACHINE.

2013-09-25 Thread Juan Lang
Hi Ben, thanks for having a whack at this. Some tests would be nice. -static HCERTCHAINENGINE CRYPT_defaultChainEngine; +/* There are two default chain engines which correspond to HCCE_CURRENT_USER and + * HCCE_LOCAL_MACHINE. +*/ +static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL, NULL

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify

2013-09-25 Thread Alexandre Julliard
Sebastian Lackner writes: > --- > dlls/winex11.drv/event.c | 99 > +++--- > 1 file changed, 58 insertions(+), 41 deletions(-) These should go in the patches that need them. Also you should start your series with reparent support, the rest doesn't make s