Hello
are there still problems with the patches:
http://source.winehq.org/patches/data/82408 and
http://source.winehq.org/patches/data/82409 ?
Thanks in advance
A+
David
Hello,
any problem with this patch
http://source.winehq.org/patches/data/80433
and this one
http://source.winehq.org/patches/data/80434
Thanks in advance
David
-- Forwarded message --
From: David Adam
Date: 2011/10/30
Subject: d3dx9_36 [patch 1/2, resent]: Implement
Hello,
please discard this patch.
It is logically wrong.
David
From ea2d22fb135d51eecf0adbc3c25b53b0d0d4ebf1 Mon Sep 17 00:00:00 2001
From: David Adam
Date: Sat, 29 Oct 2011 21:24:27 +0200
Subject: Simplify the computation of a 2-adic valuation
---
dlls/d3dx9_36/texture.c | 11 +--
1
Any problem with my D3DXCreatePolygon patch?
Thanks in advance.
David
Hello,
why did you use C++ comments ?
A+
David
+xof 0302txt 0064
> +// Copyright (C) 2011 Dylan Smith
> +//
> +// This library is free software; you can redistribute it and/or
>
>
>
>
Any feedback for the reasons why this patch and the following ones were not
commited?
Thanks in advance
A+
David
-- Forwarded message --
From: David Adam
Date: 2011/4/6
Subject: d3dx9_36 [patch 1/3; try 9]: Remove useless includes
To: wine-patches
2011/3/31 Matteo Bruni
> 2011/3/31 David Adam :
> >
> >
> > 2011/3/31 Matteo Bruni
> >>
> >> 2011/3/31 David Adam :
> >> >
> >> > + /* Check the width */
> >> > +v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_v
2011/3/31 Matteo Bruni
> 2011/3/31 David Adam :
> >
> > + /* Check the width */
> > +v1 = *((D3DXVECTOR3*)(data+19*num_bytes_per_vertex));
> > +v2 = *((D3DXVECTOR3*)(data+18*num_bytes_per_vertex));
> > +length = D3DXVec3Le
You mix S_OK with D3D_OK. Though they are equivalent, I think it would be
better to keep the only D3D_OK notation.
A+
David
2011/3/29 Rico Schüller
> ---
> dlls/d3dx9_36/core.c | 36 +++-
> 1 files changed, 27 insertions(+), 9 deletions(-)
>
>
>
>
>
>
2011/3/10 Alexandre Julliard
> Matteo Bruni writes:
>
> > 2011/3/10 David Adam :
> >> Thanks for the feedback. What do you mean by "you are forcing a
> particular
> >> vertex ordering3"?
> >
> > I mean that you are testing the vertices
> 2011/3/9 David Adam :
> > Hello,
> >
> > is there any problem with my d3dxcreatebox patch?
> >
> > Thanks in advance for any feedback.
> >
> > A+
> >
> > David
> >
>
> Do you refer to http://source.winehq.org/patches/data/71983 ?
Hello,
is there any problem with my d3dxcreatebox patch?
Thanks in advance for any feedback.
A+
David
Here is cool link to show what D3DXCreateTorus does:
http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip
A+
David
Hello,
no feedback available for this patch?
It was rejected silently.
A+
David
-- Forwarded message --
From: David Adam
Date: 2011/2/9
Subject: d3dx9_36 [resend]: Add a few tests for D3DXCreateBox
To: wine-patches
Fixed following Stefan's advices.
A+
David
When I test the following test
rc = IDirectDraw_SetCooperativeLevel(lpDD, NULL, DDSCL_FULLSCREEN |
DDSCL_EXCLUSIVE | DDSCL_CREATEDEVICEWINDOW);
ok(rc==DDERR_INVALIDPARAMS, "Expected DDERR_INVALIDPARAMS, received
%x\n", rc);
in my vista box, I receive the following failing message
ddrawm
Hello,
is there any problem with the patch for D3DXCreateBox?
I think it was not commited.
Thanks in advance for any feedback?
A+
David
OK. I missed that.
Sorry for the noise
A+
David
2010/11/14 Nikolay Sivov
> On 11/14/2010 22:41, David Adam wrote:
>
>
>
> 2010/11/14 Nikolay Sivov
>
>> On 11/14/2010 22:17, David Adam wrote:
>>
>> if(wined3d_settings.rendertargetlock_mode == RTL
2010/11/14 Nikolay Sivov
> On 11/14/2010 22:17, David Adam wrote:
>
> if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) {
>> -static BOOL warned = FALSE;
>> -if(!warned) {
>> -ERR("The application tries to lock the ren
Any problem with this patch?
A+
David
Timeout does not seem related to my patch (Anyway, I dont see how this patch
could cause a timeout)
Second failure is harmless
A+
David
2010/10/25 Stefan Leichter
> Am Monday 25 October 2010 20:11:35 schrieb David Adam:
> > Any problems with patch?
> >
>
Any problems with patch?
A+
David
-- Forwarded message --
From: David Adam
Date: 2010/10/24
Subject: ddraw: Add tests for the foreground window set by
SetCooperativeLevel
To: wine-patches
From e929b17027bebd7eb466d7e8b71efd270889e713 Mon Sep 17 00:00:00 2001
From: David Adam
Does not work for me :crying: I voluntary added trailing space to my file.
Nothing appears in red. I obtain in white and black
testcooperativelevels_normal();ESC[m
ESC[32m+ESC[mESC[32mtestcooperativelevels_normal_other_ddraw();ESC[m
ESC[32m+ESC[mESC[41mESC[m
ESC[32m+ESC[mESC[41mESC
Hello,
some comments about this patch
+if (hr != S_OK) return FALSE;
+else return TRUE;
could be simplified as
return SUCCEEDED(hr);
+trace("HRESULT when creating instance (%x)\n", hr);
Since tests are assumed to pass, we dont care about debug informations. So,
traces are useless in
Hi,
what about if ppPin is NULL?
I think that this patch needs test cases to prove that it is correct?
David
2010/8/6 Anton Khirnov
> ---
> dlls/quartz/filesource.c | 32 ++--
> 1 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/quartz/fileso
On a real Vista windows box, tests fail at
line 372: test failed: sin: Got 2: unexpected values
line 385:test failed: cos: Got 2: unexpected values
A+
David
Hello,
I would like to implement the function D3DXDeclaratorFromFVF. My numerous
attempts to do this were rejected (specially my copy/paste of the function
vdecl_convert_fvf from d3d9/vertexdeclaration.c.
Does anyone know a way to implement it?
Thanks in advance
David
Hello
many distro ship the X-server with dinput2. More and more old games work
pretty well now with Wine, but the mouse. Does anyone plan to work on the
infamous bug 6971?
It would be great if it could be implemented for the official release of
Wine. It would do a big buzz :D
Cheers
David
Hi,
patch from Tony Wasserka.
A+
David
0001-Add-a-stubbed-D3DXDeclaratorFromFVF.patch
Description: Binary data
Hello,
I removed my wine git, so I am not able to send a patch.
It would be great if you could do it.
A+
David
2010/3/23 Christian Costa
> Hello David,
>
> Indeed. shader.c has the same problem.
> Feel free to send a patch or I will do it in next patches.
>
> A+
> Chr
Hello,
the 2 lines
+ #include "d3dx9.h"
+ #include "d3dx9effect.h"
in the d3dx9_36/effect.c file are useless,
since in the d3dx9_private file, one calls d3dx9.h file which calls
d3dx9effect.h
A+
David
Hello,
since one month I have problem with Wine. With the wine-git or the
Wine binary provided by Mandriva, since I try to launch any
application I have the following message:
[da...@thakur Téléchargement]$ wine t3_demo_uk.exe
err:process:__wine_kernel_init boot event wait timed out
err:seh:raise
2009/12/3 Robert Reif
> Maarten Lankhorst wrote:
>
>> --
>> As I said, I'm confident nobody uses it, since wine never implemented it
>> properly anyway
>> ---
>>
>>
> I think you will find that you will have to add it back later because both
> interfaces are commonly used.
>
> The private interfa
cani ha scritto:
> > Il giorno dom, 25/01/2009 alle 23.19 +0100, David Adam ha scritto:
> > >
> > >
> > > 2009/1/25 Claudio Ciccani
> > >
> > > The patch implements a software fallback for vertex blending
> > > in
> &g
2009/1/25 Claudio Ciccani
>
> The patch implements a software fallback for vertex blending in
> drawStridedSlow, fixing Bug #6955.
> Although vertex blending is an old and outdated extension, there are
> still many applications(games) relying on it nowadays. This because the
> extension is genera
You need to est your email adress in your patches.
David
2008/11/12 Nicholai Benalal <[EMAIL PROTECTED]>
> Changelog:
> user32:TPM_ENTERIDLEEX needs to be set for popup windows since
> applications expect the owner window to be set for WM_ENTERIDLE. A NULL
> window made several applications, suc
Hello,
In IRC, Julliard said that this change is wrong too. :(
David
2008/9/11 Tony Wasserka <[EMAIL PROTECTED]>
> Your latest patch is already doing it right, IMPORTS must be changed to
> d3dx9_36 and IMPORTLIB must stay d3dx9.
>
>
>>
>> any idea to fix this problem?
>>
>> David
>>
>> 2008/9/1
Hi,
any idea to fix this problem?
David
2008/9/11 Tony Wasserka <[EMAIL PROTECTED]>
>
> On Mi, 2008-09-10 at 18:16 +0200, Tony wrote:
>>
>>
>>> Hi,
>>> At least for all Windows versions below Vista, the d3dx9 importlib does
>>> exist (and d3dx9_36 does not),
>>>
>>>
>>
>> I installed a recent
Hi,
Yes, I learnt that in IRC. But there is a real problem. With a native box,
there is no d3dx9.dll. So, wine-test mustn't call it.
Currently, wine-test calls it and all the tests are skipped in a real
windows box. You can check it in the wine-webpage that collects all the
test results.
David
Hello,
A few remarks:
1) this patch is too huge
You need to split it in several patches. I advice you to do a patch for
- d3dx9effect.h
-an another one for d3dx9shader.h
-an another one for D3DXCreateEffect
-an another one for D3DXCreateEffectExW and D3DXCreateEffectExW
2) for the patch D3DXCrea
Hello,
could you keep the style of the file, please?
For instance
for (.)
{
}
instead of
for (.) {
}
The same for the if condition and the switch condition?
David
Hi,
some remarks
+if (((*poutscale).x==0)||((*poutscale).y==0)||((*poutscale).z==0))
should be
+if ((poutscale->x==0)||(poutscale->y==0)||(poutscale->z==0))
No need to redefine a module fonction
Replace +poutscale->x=module(pM->m[0][0],pM->m[0][1],pM->m[0][2]);
by
+
poutscale->x=D3D
Since the prototype for D3DXCreateSprite in d3dx9 and d3dx8 are not
compatible, it would be worth to do the implementation in parallel (that is
in the same patch), instead of duplicating the d3dx9 patch into the d3dx8
one.
David
Hello,
maybe you should do this for every d3dx9_xx dll, not only the d3dx9_28 one.
David
Yes, it is exactly that. So, I wonder why the patches were not committed.
David
2008/6/11 Stefan Dösinger <[EMAIL PROTECTED]>:
> > So why are you adding the check that is not present on windows? What
> > are th
> > reasoning to have this if it clearly absent in native implementation?
> As I unde
I sent a patch to removed these test earlier.
>
>> So why are you adding the check that is not present on windows? What are
> th reasoning to have this if it clearly absent in native implementation?
That's why I removed it form wined3d. I set the check in ddraw, since only
ddraw checks it.
Dav
>David Adam wrote:
>>* The test succeded in my windows XP box.
*>>*
*>You have only ddraw test and no d3d test.
>
>Vitaliy.
Giving a NULL value to SetMaterial in d3d9 or d3d8 makes Windows crashes.
It is a forbidden value (see bug 13646). So, no test can be performed
for
Hello
>-devmode->dmSize = sizeof(DEVMODEW);
>-devmode->dmSpecVersion = MAKEWORD(1,4);
>-devmode->dmDriverVersion = MAKEWORD(1,4);
>+devmode->dmSize = FIELD_OFFSET(DEVMODEW, dmICMMethod);
>+devmode->dmSpecVersion = DM_SPECVERSION;
>+devmode->dmDriverVersion = DM_SPECVERSION;
this function does, ( and better knows a possible
implementation)?
Thanks,
David Adam
On 08/04/2008, David Adam http://www.winehq.org/mailman/listinfo/wine-patches>> wrote:
>* +This->current = This->current +1;
*>* +HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, This->matrix,
(This->current +1) * sizeof(D3DXMATRIX) );
*>* +if ( Th
Hello,
to keep the code readable, you should put your function in a new file. For
instance,
d3dx8/mesh.c would be fine (msdn put this functio in the mesh category).
Otherwise, the whole code is going to implemented in the file
d3dx8/d3dx8_main.c.
What is the purpose of the line
+ok(TRUE,"pr
I agree that the good implementation is with array.
The bad thing is that we must bound the size of the array ourself. I think
that a size of 64 or 128 for the array is enough, right?
The advantage of a list is that we do not need to take care about the size.
David
Here are my wishes for GSOC:
D3DX dlls begin to be implemented. It seems that this could be a good GSOC
to implement more feature of this dll, in particular the shader compiler.
In the view of wined3d, I think about vertex blending, since there are tons
of game using this feature.
Stefan, is this
My second patch was not committed, because Alexandre wants all the
functions to be implemented in d3dx9-36.dll. Then, the other d3dx9_xx
dll forward their functions to d3dx9_36.dll.
David
Following Alexandre (and I agree with him :D ), one only needs to
export the functions of d3dx9_36 (the latest one) to the older
d3dx9_xx dlls.
So, we just just need to implement the functions in the d3dx9_36 dll
repertory.
No wine_d3dx9 is useful.
David
Robert Shearman <[EMAIL PROTECTED]> a écrit :
> Alexandre Julliard wrote:
>> /*_D3DXQUATERNION*/
>> -D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION *
>> pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION * pq2)
>> +D3DXQUATERNION* WINAPI D3DXQu
Doing that, I shall break the style of the file. I tried to keep a
uniformized style for the whole repertory.
David
Any chance the formatting can be improved to include whitespace
between blocks and proper indentation?
Hello,
In the beginning, I thought to share the code between d3drm and d3dx8,
but unfortunelaty, it was not a good idea, since the structure
quaternion is not the same in the both dll (definitively 4 floats, but
4 floats in d3dx8, 1 float and a d3drmvector in d3drm). So, it was not
pretty.
Hello,
my first "real" patches for wine were accepted. I would to thank all
wine people for their kindness, and their help to make these patche
accepted.
Now I can play Motocross Madness 2 out the box :D :D :D
Specially, I would like to thanks Vijay for his help to start the
implementati
Hi all,
my patches for D3DRM have not been applied yet. I thought to have
made all the requested changes. But it seems no.
So, am I in the good way? What changes must I make now?
These patches fix Bug 7442 also.
Thanks you in advance for any advice and suggestion.
David Adam
PS: I follow
59 matches
Mail list logo
