Re: Windows API on Linux

2013-03-30 Thread Joris Huizer
On 03/29/2013 01:27 PM, Abhinav Jangda wrote: Hello everyone, I'm working on a project which aims to develop a port of Windows API on Linux, so that programs written using Windows API could directly be compiled and executed on Linux with its native look and feel. Anyone, interested in working o

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread Joris Huizer
On 10/21/2012 05:49 PM, James Eder wrote: On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson wrote: On 10/20/2012 05:40 PM, James Eder wrote: +/* Intel says we need a zeroed 16-byte aligned buffer */ +char buffer[512 + 16]; +XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULONG_PTR)buf

Re: [SOLVED] Debugging Wine with Lightroom 3.5

2012-01-18 Thread Joris Huizer
On 01/18/2012 10:10 PM, Roland Baudin wrote: You can find the attached complete patch against wine 1.3.35. Hello Roland, Please send patches to wine-patches. Unless you are asking for feedback? HTH, Joris

Re: Debugging Wine with Lightroom 3.5

2011-12-18 Thread Joris Huizer
Replying, also including the wine-devel list, On 12/17/2011 05:15 PM, Roland Baudin wrote: Hi, thanks for the answer. What do you mean by "a different execution path"? RB The application might decide to execute different code given the Vista settings. It may have a preferred execution path u

Re: Debugging Wine with Lightroom 3.5

2011-12-17 Thread Joris Huizer
It's possible the application is choosing a different execution path, using Vista-specific features. This could be an explanation for the differences you are seeing. HTH, Joris

Re: comctl32/tests: Removed sign comparison warning in datetime tests.

2011-10-05 Thread Joris Huizer
On 10/05/2011 04:43 PM, Marko Nikolic wrote: static void test_mccolor_types(HWND hWndDateTime, int mccolor_type, const char* mccolor_name) { -LRESULT r; -COLORREF theColor, prevColor; +//LRESULT r; +COLORREF theColor, prevColor, crColor; Please avoid C++/C99-style comments i

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)

2011-08-23 Thread Joris Huizer
Just an implementation detail I noticed: On 08/23/2011 11:45 AM, Hans Leidekker wrote: + +static UINT get_registered_local_package( const WCHAR *product, const WCHAR *package, WCHAR *localfile ) +{ +MSIINSTALLCONTEXT context; +HKEY product_key, props_key; +WCHAR *registered_package

Re: urlmon: Fix incorrect pointer arithmetic (too conversative) in map_url_to_zone. (RESEND)

2011-06-05 Thread Joris Huizer
On 06/04/2011 03:02 PM, Gerald Pfeifer wrote: Resending: This really looks like a straightforward bug fix and the current code definitely wrong??? The difference between two pointers (of the same type) is the number of elements, not the number of bytes. Thus the code below was way incorrect,

Re: [PATCH 1/4] winealsa.drv: Partially implement IAudioSessionManager2

2011-06-03 Thread Joris Huizer
I'm sorry if I'm wrong, but it seems to me in this and following patches, the AudioSessionManager_Release() function is incomplete - I think the dealing with ref == 0 is missing. HTH, Joris

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

2011-05-26 Thread Joris Huizer
On 05/26/2011 10:33 AM, Michael Mc Donnell wrote: I've added some more tests to see if I could make it fail. Microsoft's UpdateSemantics is not very picky. I can't get it to return anything but D3D_OK except for when I pass a null pointer. My implementation follows this behavior except for two c

Re: [2/2] d3dx9: Implement D3DXLoadMeshHierarchy for basic mesh hierarchy.

2011-05-19 Thread Joris Huizer
On 05/19/2011 06:34 PM, Dylan Smith wrote: On Thu, May 19, 2011 at 6:16 AM, Joris Huizer wrote: Hello, I found a possibly memory leak in the patch. In this function: +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data *mesh_data, DWORD provide_flags) These may leak the

Re: [2/2] d3dx9: Implement D3DXLoadMeshHierarchy for basic mesh hierarchy.

2011-05-19 Thread Joris Huizer
Hello, I found a possibly memory leak in the patch. In this function: +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data *mesh_data, DWORD provide_flags) These may leak the allocated blocks: + +mesh_data->vertices = HeapAlloc(GetProcessHeap(), 0, +mesh_da

Re: d3dx9_36: Implement D3DXCreateBox

2011-03-27 Thread Joris Huizer
Hello, In this patch, one part seemed strange to me: You are declaring vertices as static memory: +static FLOAT vertices[144] But you are changing the values during the function: + +for(i = 0; i< 24; i++) +{ +vertices[6 * i] *= width; +vertices[6 * i + 1] *= he

Re: [PATCH] Label verbosity levels.

2011-03-19 Thread Joris Huizer
On 03/19/2011 11:32 PM, Vitaliy Margolen wrote: On 03/18/2011 09:24 PM, m...@mtew.isa-geek.net wrote: - if ($opt_verbose> 0) - { -print "Processing ".$spec_name."\n"; - } + print "Processing ".$spec_name."\n" +if $opt_verbose>= $VERBOSE_INPUT; Please don't do this reverse notation.

Re: cryptnet/tests: Partially revert commit de6e33f306a3b1b424ad1a9c41e85d3692ef9e4d

2011-03-11 Thread Joris Huizer
Hello, I found a small (copy/paste) mistake in this patch: -/* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH */ -ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH), +/* w2k3,XP, newer w2k: CRYPT_E_NO_MATCH, older w2k: CRYPT_E_ASN1_BADTAG */ +ok(!ret && (GetLastError() == CRYPT_E_NO_MATCH || +

Re: [1/3] msxml3/xsl: Basic put_input() method for IXSLProcessor (try2)

2011-02-16 Thread Joris Huizer
Hello, I think I found a (possible) little issue in the patch: If one would pass a VARIANT of incorrect type to the xslprocessor_put_input() function (say type BSTR), the first type checks fail and leave hr uninitialised; in case it happened to have the value S_OK the other if block is skipped

the patches around ok()

2011-02-04 Thread Joris Huizer
Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent.

2011-02-04 Thread Joris Huizer
Hello Dmitry Timoshkov, I noticed a small issue in your patch: > > -    ret = DestroyWindow(parent); > -    ok( ret, "DestroyWindow() error %d\n", > GetLastError()); > +    ok(DestroyWindow(parent), "DestroyWindow() > error %d\n", GetLastError()); Please don't merge the call with the ok() stat

Re: programs: Add winemsibuilder.

2011-02-01 Thread Joris Huizer
While skimming through the new patches, I found: > +WCHAR *encode_stream( const WCHAR *in ) > +{ > +    DWORD c, next, count; > +    WCHAR *out, *p; > + > +    count = strlenW( in ); > +    if (count > MAX_STREAM_NAME) > +        return NULL; > + > +    count += 2; > +    out = HeapAlloc( GetProce

Re: [PATCH 4/4] comctl32/rebar: Implemented dragging between rows

2011-01-11 Thread Joris Huizer
Hello, In this patch, in function REBAR_HandleUDDrag: +if(yOff < 0) +{ +/* Place the band above the current top row */ +DPA_DeletePtr(infoPtr->bands, iHitBand); +hitBand->fStyle &= RBBS_BREAK; +REBAR_GetBand(infoPtr, 0)->fStyle |= RBBS_BREAK; +infoP

Re: [1/2] msi: Don't try to install or remove ODBC drivers if the component is disabled.

2010-12-09 Thread Joris Huizer
Hello, I noticed in this patch, exactly the same lines are added in all the functions; wouldn't it be better to add a(n) (inline) function isComponentEnabled(rec,package) to reduce the repetition? HTH, Joris

Re: About: d3dx9: Store transform matrix per-sprite.

2010-10-20 Thread Joris Huizer
--- On Tue, 10/19/10, Austin English wrote: > While these emails are very helpful, can you please do a > reply to the > original thread? It makes it easier for those of us using > clients with > threaded mode to follow. > > Thanks! > > -- > -Austin > I can understand that's easier, less mes

About: d3dx9: Store transform matrix per-sprite.

2010-10-19 Thread Joris Huizer
Hello, In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like: int i, count, start; /* ... */ for(start=0;startsprite_count;start+=count,count=0) { i=start; while(isprite_count && (count==0 || This->sprites[i].texture==This->sprites[i-1

About: msxml3: Partially implement ::setAttributeNode()

2010-10-18 Thread Joris Huizer
Hello, In proposed patch msxml3: Partially implement ::setAttributeNode() I think I found a little possible memory leak: +name = xmlChar_from_wchar(nameW); +value = xmlChar_from_wchar(V_BSTR(&valueW)); + +if (!name || !value) +{ +SysFreeString(nameW); +VariantClear

About: [PATCH 2/2] ntdll: Check for case-insensitive volumes.

2010-10-18 Thread Joris Huizer
Hello, In the proposed patch "[PATCH 2/2] ntdll: Check for case-insensitive volumes.", I found this piece: +/* Add a new entry */ +for (i = 0; i < sizeof(fs_cache)/sizeof(fs_cache[0]); i++) +if (fs_cache[i].dev == 0) +{ +/* This entry is empty, use it */ +

Error path issues with "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics."

2010-09-29 Thread Joris Huizer
Hello, I noticed the committed patch "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics." (5cac9d2cb2c020802a56a5b1b28348316f1087ba) The GAMEUX_getAppIdFromGDFPath() function now ends with: +HeapFree(GetProcessHeap(), 0, lpRegistryPath); + +TRACE("found app id: %s,

Unused code patch in: "mshtml: Added nsIURL::GetQuery implementation."

2010-09-18 Thread Joris Huizer
Hello, I found a bit of unused code was introduced in commit ffe9cc87c0e759dffe2a19a96a1e5c7746c7ad62 "mshtml: Added nsIURL::GetQuery implementation." +ptr_end = url.lpszExtraInfo+url.dwExtraInfoLength; +for(ptr = url.lpszExtraInfo; ptr < ptr_end; ptr++) { +if(*ptr == '#') +

Mistake in : msxml3: Don't use xmlnode's IXMLDOMNode iface in get_[first|last]Node implementations.

2010-09-08 Thread Joris Huizer
Hello, I noticed some copy/paste mistake in this patch; A number of functions for *get_lastChild now call node_get_first_child. HTH, Joris

Typo in : wined3d: Translate before scaling for rhw as well in transform_projection().

2010-09-07 Thread Joris Huizer
While skimming through recently committed patches, I noticed this piece: +/* Window Coord 0 is the middle of the first pixel, so translate by 1/2 pixels */ +glTranslatef(63.0f / 128.0f, 63.0f / 128.0f, 0.0f); +checkGLcall("glTranslatef(63.0f / 128.0f, -63.0f / 128.0f, 0.0f

[PATCH 5/6] d3dx9_36/tests: Added trigonometric functions test to HLSL test suite

2010-08-05 Thread Joris Huizer
Hello Travis Athougies, In this patch, you have this code: +void *ret = NULL; //... +ret = HeapAlloc(GetProcessHeap(), 0, 4 * samples); +for(i = 0;i < 32;i++) { //... +memcpy((void*) (((DWORD) ret) + (4 * i)), lr.pBits, 4); //... +} I'm not sure, but I think this will cau

[2/3] ntdll: fill unused tails of heap blocks if HEAP_FREE_CHECKING_ENABLED (take 3)

2010-01-08 Thread Joris Huizer
Dan Kegel, you wrote: To check whether we're too early in process setup to check global flags, I compare the arguments of RtlCreateHeap with the ones used by the call in virtual_init(). This is not especially clean, but I couldn't think of anything better. I was thinking, couldn't you place the

cppcheck Sept 18

2009-09-20 Thread Joris Huizer
[/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd These two are false positives, as the process ends (calling exit(1) [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible

Simplify code in dlls/imm32/tests/imm32.c

2009-06-20 Thread Joris Huizer
Hello Gerald Pfeifer, You did, /* behavior differs between win9x and NT */ ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr)); -ok(ret || !ret, "You'll never read this.\n"); +ok(TRUE, "You'll never read this.\n"); Wouldn't it be better to do something lik

possible-wrong return value of PdhMakeCounterPathA

2009-05-10 Thread Joris Huizer
Obviously mostly a small and theoretical problem, but anyway: Looking at git commit 754b97c72c38f736100c6542af234c31a4bf7a5b, it seems, PdhMakeCounterPathA may be returning the wrong error in this case: Everything goes well until the allocation of bufferW. Assuming this fails, the function will

Re: possible NULL dereference?

2009-04-09 Thread Joris Huizer
--- On Thu, 4/9/09, Paul Vriens wrote: > From: Paul Vriens > Subject: Re: possible NULL dereference? > To: "Joris Huizer" > Cc: wine-devel@winehq.org > Date: Thursday, April 9, 2009, 7:53 AM > Joris Huizer wrote: > > Looking at git commit > dcb3e52e2dfd0

possible NULL dereference?

2009-04-08 Thread Joris Huizer
Looking at git commit dcb3e52e2dfd0d6e494164932fb2b684d463a005, it seems, passing a NULL size pointer to GetUserNameEx[AW] is likely to crash. You may want to test whether Windows versions crash on it, and check for it if needed. HTH, Joris

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something

2009-04-02 Thread Joris Huizer
--- On Thu, 4/2/09, Nikolay Sivov wrote: > From: Nikolay Sivov > Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually > test something > To: wine-devel@winehq.org, joris_hui...@yahoo.com > Date: Thursday, April 2, 2009, 2:04 PM > > Joris Huiz

Re: msxml3/tests:domdoc.c Test doc pointer before using it (coverity)

2009-01-23 Thread Joris Huizer
--- On Thu, 1/22/09, Austin English wrote: > From: Austin English > >From: Joris Huizer > > Your e-mail is messed up in the patches. Alexandre's > scripts take the > patch info over the e-mail headers, so you should fix that. > > -- > -Austin Sorry ab

Internet Explorer running in Wine usefull for performance testing

2008-11-25 Thread Joris Huizer
Hello, Just as Dan Kegel likes to announce on the list, how Wine gets mentioned out on the internet, I thought this may be interesting/motivating to you. This page, http://ejohn.org/blog/accuracy-of-javascript-time/, mentions (big) problems in testing javascript performances (there's some inter

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-20 Thread Joris Huizer
--- On Sun, 10/19/08, Rob Shearman <[EMAIL PROTECTED]> wrote: > > The information is added at commit time so it won't > make any > difference if you just run "git format-patch" > after configuring the > above settings, it matters what the settings were when you > committed. > > If you haven't com

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-19 Thread Joris Huizer
--- On Fri, 10/17/08, Austin English <[EMAIL PROTECTED]> wrote: > > git repo-config user.name "Your Name" > git repo-config user.email "[EMAIL PROTECTED]" > Uhm no that doesn't work. I had already tried that (or actually, the equivalent of adding these to .git/config) but it didn't make any dif

Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

2008-10-17 Thread Joris Huizer
--- On Thu, 10/16/08, Austin English <[EMAIL PROTECTED]> wrote: > > "From: Joris Huizer > <[EMAIL PROTECTED](none)>" > > Minor, but please fix your e-mail in the patch: > > Also, please set patch extensions to .txt, it makes it > easier to read >

Re: gdiplus: font.c: ensure to release resources

2008-06-26 Thread Joris Huizer
--- On Thu, 6/26/08, Huw Davies <[EMAIL PROTECTED]> wrote: > > You need to select out the hfont before deleting it. > > So the SelectObject should look like > hfont_old = SelectObject(hdc, hfont); > then after the > GetTextMetrics > do > DeleteObject(SelectObject(hdc, hfont_old)) > > (then you

old dos/windows program crashing

2007-09-15 Thread Joris Huizer
Hello, I have a program, that I got like ages ago. It effectively is an atari emulator for dos, by the name "pacifist", but I originally got it installed under windows ME. It has an old atari-basic program "installed" in it, (a simple game) written by a friend in it, which I wanted to play. I dec

Re: Propsheet exception fix

2007-04-03 Thread Joris Huizer
--- Aric Stewart <[EMAIL PROTECTED]> wrote: > Do not attempt to draw a page during WM_PAINT if > there is no active page. > Test which shows this working, causes exception > without this patch > Exception pointed out by EA Durbin. I in no way am in a position to criticise, but if it turns out no

Re: automatically running wineprefixcreate

2007-03-22 Thread Joris Huizer
--- Tom Spear <[EMAIL PROTECTED]> wrote: > > Because I have a 20gb drive that Linux is installed > on, and a blank > 40gb mounted at /mnt/d (there is no windows > installed on it). I want > wine to install its things to my 40gb, and just for > no other good > reason than the fact that I am makin

comctl32/tests: test failures

2007-03-17 Thread Joris Huizer
I was looking at comctl32 files for signedness fixes (there's a lot of signedness warnings, though many can't be fixed easily) Just to be sure, I now and then check with `make test` just to catch mistakes I might have made -- though on this dll 'header' tests fail: header.c:1310: Test failed: Tes

Re: Add casts to tools/makedep.c

2007-03-13 Thread Joris Huizer
--- Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Gerald Pfeifer" <[EMAIL PROTECTED]> wrote: > > > I accidently ended up building Wine using a C++ > compiler the other day, > > and came across the following. > > > -char *p = xmalloc (size); > > +char *p = (char*) xmalloc (size)

Re: HtmlHelp status, winecfg and SoC proposal

2007-03-06 Thread Joris Huizer
--- Paul Wise <[EMAIL PROTECTED]> wrote: > The licence says this: > > > * Limitations on Reverse-Engineering, > Decompilation, and Disassembly. > > You may not reverse- engineer, decompile, or > disassemble the SOFTWARE > > PRODUCT, except and only to the extent that such > activity is expressly

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Joris Huizer
--- Frank Richter <[EMAIL PROTECTED]> wrote: > On 03.03.2007 13:56, Joris Huizer wrote: > > > > if( i == 0 ) > > - memcpy( &lpSpData->dwReserved1, > returnBuffer, > > sizeof(lpSpData->dwReserved1) ); > > +

Re: DirectPlay should convert dwReserved1/2 registry keys from strings to DWORDs

2007-03-03 Thread Joris Huizer
if( i == 0 ) - memcpy( &lpSpData->dwReserved1, returnBuffer, sizeof(lpSpData->dwReserved1) ); + sscanf(returnBuffer, "%x", &lpSpData->dwReserved1); Couldnt you use: strcpy(lpSpData->dwReserved1,returnBuffer); Sorry for only replying now; Your solution is equivalent, e

RE: xcopy try 3

2007-02-27 Thread Joris Huizer
--- Ann & Jason Edmeades <[EMAIL PROTECTED]> wrote: > > For reference, in case anyone else hits it, the > problem here is I like my > windows editor so generally edit over a samba share. > (I've just found...) Makes me feel like why not use wine to run it...? Oh well, just babbling, you must ha

Re: a big fan (now with bad news)

2007-02-24 Thread Joris Huizer
#x27;s been an invasion-- i thought i mailed to the "list" last time, but it looks like i sent just to you last time? (and i know i sent only to you this time, so if you wish to forward to the list, please do so. i have a real problem w/ being not-concise [as you've noticed, i'm

RE: a big fan (now with bad news)

2007-02-23 Thread Joris Huizer
--- Jeffrey Sabarese <[EMAIL PROTECTED]> wrote: > > I tried [ yum remove wine ], and then [yum install > wine] which went > without a hitch, but there's no change in my Primary > User (the broken > one) > HOWEVER, WinE continues to run perfectly under other > user accounts, and ROOT. > The win

Re: a big fan of your work

2007-02-20 Thread Joris Huizer
--- Jeffrey Sabarese <[EMAIL PROTECTED]> wrote: > I have installed, and use the "ies4linux" > ( here for more info if you're unfamiliar with it: > http://novicenotes.com/install-internet-explorer-on-linux-under-wine-run-ie-on-linux/ > ), but though it works VERY well launching from the > Fedora Te

Re: -ansi, -pedantic warnings and errors on

2007-02-17 Thread Joris Huizer
Robert Shearman <[EMAIL PROTECTED]> wrote: Joris Huizer wrote: > Hello, > > I was looking at the result of configuring with -ansi, > -pedantic flags. It gives loads of warnings (not all > relevant - also complaining about 'long long' not > being ansi) and ind

-ansi, -pedantic warnings and errors on

2007-02-17 Thread Joris Huizer
d flight and hotel bargains. http://farechase.yahoo.com/promo-generic-14795097>From f832d27650482cc0b764f1600bb571cd7240fb7b Mon Sep 17 00:00:00 2001 From: Joris Huizer <[EMAIL PROTECTED](none)> Date: Sat, 17 Feb 2007 14:07:11 +0100 Subject: [PATCH] -pedantic fix: make unicode functions

git question

2007-02-16 Thread Joris Huizer
Hello, As a new wine is released I'm trying to get updated. Before I had used git for generating patches, I could do: git fetch; git rebase origin however, now this doesn't seem to pickup anything. How should I tell git to actually update to the files on the server? Thanks, Joris _

avifil32: sign-compare fixes

2007-02-15 Thread Joris Huizer
Joris Never miss an email again! Yahoo! Toolbar alerts you the instant new Mail arrives. http://tools.search.yahoo.com/toolbar/features/mail/>From 1bc8e723684ad790ac7062334dcbebb37e0dc791 Mon Sep 17 00:00:00 2001 Fro

Re: wineboot: Start items in StartUp folder on boot, includes security measures.

2007-02-11 Thread Joris Huizer
It seems the patch itself got lost Food fight? Enjoy some healthy debate in the Yahoo! Answers Food & Drink Q&A. http://answers.yahoo.com/dir/?link=list&sid=396545367

signedness/WINAPI changing question

2007-02-10 Thread Joris Huizer
I have a small question: I find some function LONG WINAPI AVIStreamSampleToTime(PAVISTREAM pstream, LONG lSample) (in the avifil32 dll), the second parameter should really be an ULONG instead of a LONG. It'd fix the signedness problems. My question is, is such a change allowed? And what should

Re: winegcc: sign-compare fixes

2007-02-08 Thread Joris Huizer
--- "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > On 2/7/07, Joris Huizer <[EMAIL PROTECTED]> > wrote: > > I believe this one causes problems -- please do > not commit yet > > > > Joris Huizer <[EMAIL PROTECTED]> wrote: > > > &

Re: advapi32: sign-compare fixes

2007-02-07 Thread Joris Huizer
Vitaliy Margolen <[EMAIL PROTECTED]> wrote: Joris Huizer wrote: > - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, > + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName, This isn't right. WideCharToMultiByte returns INT, which is signed. >

Re: winegcc: sign-compare fixes

2007-02-07 Thread Joris Huizer
Joris Huizer <[EMAIL PROTECTED]> wrote: I believe this one causes problems -- please do not commit yet Sorry for the spamming - the patch should be alright - Everyone is raving about the all-new Yahoo! Mail beta.

Re: winegcc: sign-compare fixes

2007-02-07 Thread Joris Huizer
I believe this one causes problems -- please do not commit yet Joris Huizer <[EMAIL PROTECTED]> wrote: - Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users.>From 8686a200bd1f1cbd934d761013c487a9ddc195c9 Mon Se

Re: [urlmon 1/2] Cast-qual warning fix

2007-02-07 Thread Joris Huizer
--- Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > Fix a warning and remove the now not needed cast. > > Changelog > Cast-qual warning fix > > Cheers, > > Paul. > > > > diff --git a/dlls/urlmon/umon.c b/dlls/urlmon/umon.c > index 49260ab..d593c81 100644 > --- a/dlls/urlmon/umon.c > +

Re: Pen Widths, and patch etiquette

2006-07-11 Thread Joris Huizer
You may want to try and write a regression test (a small amount of C code calling the function/functions in such a way that the problem you see can be seen as output value) to show what windows does in this case; if then the values are corrected under wine with your changes, it shows you're goi

make installs recompiles files

2006-07-11 Thread Joris Huizer
Hello, I have this question: I noticed make install recompiles a number of files; it appears to happen in these directories: libs/wine dlls/uuid dlls/hhctrl.ocx dlls/shdocvw dlls/shlwapi It seems every source file of these directories gets recompiled. This happens with source of wine 0.9.17;

Re: [ntdll][3/3] Fix returncode for NtDeleteKey (with test)

2006-07-06 Thread Joris Huizer
Paul Vriens wrote: The server needs to check the handle anyway, there's no reason to do the check twice. Why twice? I return right after the NULL check. Paul. I think he meant, if there is a NULL check in the server code, the NULL check gets executed twice if it isn't NULL; the first one

Re: [setupapi] fix return values and GUID string in SetupDiOpenClassRegKeyExW

2006-07-03 Thread Joris Huizer
Damjan Jovanovic wrote: +guidStringWithBraces[0] = (WCHAR) '{'; +CopyMemory(&guidStringWithBraces[1], lpGuidString, +(MAX_GUID_STRING_LEN - 3)*sizeof(WCHAR)); +guidStringWithBraces[MAX_GUID_STRING_LEN - 2] = (WCHAR) '}'; +guidStringWithBraces[MAX_GUID_STRING_LEN - 1] = 0;

Re: setupapi: Fix SetupCloseInfFile when a NULL handle is given, with tests

2006-06-24 Thread Joris Huizer
James Hawkins wrote: Hi, This fixes bug 5511. Changelog: * Fix SetupCloseInfFile when a NULL handle is given, with tests. dlls/setupapi/parser.c |2 ++ dlls/setupapi/tests/parser.c |9 + 2 files changed, 11 insertions(+), 0 deletions(-) -- James Hawkins -

Re: secur32: Implement QueryContextAttributes. Add tests. cbMaxToken is 1904 not 2010.

2006-06-15 Thread Joris Huizer
Kai Blin wrote: +case SECPKG_ATTR_SIZES: +{ +PSecPkgContext_Sizes spcs = +SECUR32_ALLOC(sizeof(SecPkgContext_Sizes)); +spcs->cbMaxToken = NTLM_MAX_BUF; +spcs->cbMaxSignature = 16; +spcs->cbBlo

msi: sql parsing

2006-06-10 Thread Joris Huizer
Hello, As somebody asked me whether I could try to use MSN Beta 8, I decided to give it a try; The installer quits at some point, caused by an unhandled SQL command "ALTER TABLE `Registry` HOLD" I decided to have a look at this, but I'm not familiar with msi, and my SQL knowledge isn't very bi

Re: netapi32: Improve NetUserGetInfo function

2006-06-10 Thread Joris Huizer
Simon Kissane wrote: netapi32: Improve NetUserGetInfo function * Implemented support for all levels documented by MSDN * Corrected error codes for nonexistent levels * Now works with empty string as server name I have also attached a C program (which can be compiled with MINGW), which tests the

Re: appdb security

2006-06-09 Thread Joris Huizer
Tobias Burnus wrote: Why don't you use mysql_escape_string(...)? http://de.php.net/manual/en/function.mysql-escape-string.php Tobias The page says it's deprecated and mentions using mysql_real_escape_string instead (http://nl2.php.net/mysql_real_escape_string) HTH, Joris

Re: MAPI32: implement FGetComponentPath

2006-05-26 Thread Joris Huizer
Dmitry Timoshkov wrote: +static const char * const fmt[] = { "%d\\NT", "%d\\95", "%d" }; +char lcid_ver[20]; +UINT i; + +for (i = 0; i < sizeof(fmt)/sizeof(fmt[0]); i++) +{ +/* FIXME: what's the correct behaviour here? */

Re: WineD3D: SetDisplayMode and GetDisplayMode

2006-05-19 Thread Joris Huizer
Stefan Dösinger wrote: Am Donnerstag, 18. Mai 2006 22:31 schrieb Stefan Dösinger: + +ret = ChangeDisplaySettingsExW(NULL, &devmode, NULL, CDS_FULLSCREEN, NULL); +if (ret != DISP_CHANGE_SUCCESSFUL) { +if(devmode.dmDisplayFrequency != 0) { +WARN("ChangeDisplaySettings

OT: just a greeting

2006-05-05 Thread Joris Huizer
Hey, seeing you emailing again Alexandre Julliard, welcome back, hope you enjoyed your vacation :-) regards, Joris

Re: advpack [2/17]: Install the OCX in RegisterOCX

2006-05-04 Thread Joris Huizer
James Hawkins wrote: Hi, Changelog: * Install the OCX in RegisterOCX. dlls/advpack/advpack.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) -- James Hawkin s it seems the attachment is em

Re: [usp10] Fix return-codes of ScriptGetFontProperties (resend)

2006-04-20 Thread Joris Huizer
Paul Vriens wrote: +/* Now a NULL hdc again */ +hr = ScriptGetFontProperties(NULL,&psc,&sfp); +/* Save the psc pointer */ +old_psc = psc; +ok( hr == S_OK, "(NULL,&psc,&sfp), expected S_OK, got %08x\n", (unsigned int)hr); +ok( psc == old_psc, "Expected psc not to be change

Re: Using msvcmon to debug

2006-04-20 Thread Joris Huizer
Uwe Bonnes wrote: "Ryan" == Ryan Miller <[EMAIL PROTECTED]> writes: Ryan> Hi, I've been using msvcmon previously to remote debug application Ryan> in Visual Studio on Wine. It's great to have an IDE to debug Wine Ryan> with the breakpoints and watch windows and all. I'm now using

Knights and merchants (valgrind)

2006-04-15 Thread Joris Huizer
Hello, As suggested earlier on the list, I ran this game with valgrind (at last I tried again with svn, which works better than trying to patch 3.1.1) There are a few problems: valgrind comes with loads of errors, but only indicates which file (*.so) the errors come from (so I need to compile

Re: [EMAIL PROTECTED]

2006-04-14 Thread Joris Huizer
Kuba Ober wrote: On Friday 14 April 2006 15:25, Chris Morgan wrote: Just thought that I would throw out the point that it isn't likely that SETI at home will ever find any intelligent signals and that it is mostly a waste of energy to look for them given our long distance to nearby galaxies and

Re: Coverity doing scans of Wine codebase!

2006-04-07 Thread Joris Huizer
Tom Spear wrote: On 4/7/06, *Michael Stefaniuc* <[EMAIL PROTECTED] I couldn't agree more. Matter of fact I recall that this is the reason that the KLEZ virus from a few years ago was able to infect a linux system running outlook express on wine, as well as why certain games crash (they wor

Re: Why winetools is utterly useless, once and for all.

2006-03-28 Thread Joris Huizer
Segin wrote: There is one reason, inarguable (if you reply to this you have a IQ of 0) as to why WineTools is useless: Most of the WineTools 'magic' is in it's ~/.wine/config file, which Wine no longer uses/acknoleges, thefore, WineTools is utterly useless and has no point in existing AT ALL, P

Re: function counting script, memcheck.sh

2006-03-20 Thread Joris Huizer
Segin wrote: Attached is version 0.2 of this script, with a lot of additional functionality. You will need to be able to write to /tmp and make a file /tmp/grep to use the extended functionality (default functionality needs none of that, and is unmodified.) Your message does not have the sc

Re: Function counting script

2006-03-19 Thread Joris Huizer
Segin wrote: It's not a C interpeter, it's literally a frint end of sorts to grep. There's only one textual occurence of malloc() in the code, so it only returns one. Think before you speak. P.S. I'll add a C interpeter when there becomes a need for one. It was my impression that the goal

Re: Function counting script

2006-03-18 Thread Joris Huizer
Segin wrote: As my small contribution, attached is a small shell script that, unmodified, finds out how many times certain functions are called in a given sample of files. The default functions are 'malloc', 'realloc', and 'free', and the sample files are all files ending in .c in the current

Re: How hard would it be to support Java?

2006-03-18 Thread Joris Huizer
Christoph wrote: Dan Kegel schrieb: Quite a few apps use embedded JVM's. Case in point: SPSS, one of the apps requested by Munich. WTF? There is a JVM for Linux available. To my mind contact the manufacture of your software and explain to them that Java is platform independent ... Having

Re: Recently created font problem - anyone see similar?

2006-03-03 Thread Joris Huizer
Dr J A Gow wrote: Hi, I found that the following patch, committed to CVS on 23/02/06 at 20:33:06 made all my Wine system fonts squashed up and unreadable, which in turn made a mess of formatting in some dialog boxes. I backed the patch out from a current tree and the problem went away. Anyon

Re: Winelib

2006-02-19 Thread Joris Huizer
Michael King wrote: Hi, I'm looking into porting our graphic application language to Linux usign WineLib but having some trouble just getting started. I downloaded and installed wine-0.9.8-SuSELinux92.i586.rpm for our SUSE 9.2 system and then tried to create the 'notepad' program using the in

Re: Fwd: game "Knights and Merchants" deadlocks

2006-02-08 Thread Joris Huizer
Andreas Mohr wrote: Hi, On Sat, Feb 04, 2006 at 01:47:42PM +0100, James Trotter wrote: On 2/4/06, Joris Huizer <[EMAIL PROTECTED]> wrote: I have this question: I have a game called "Knights and Merchants" which I sometimes play; I find it deadlocks each time after playing f

Re: VC++ demangling tool

2006-02-07 Thread Joris Huizer
Eric Pouech wrote: Michael Stefaniuc wrote: Hello! winedump has a VC++ symbol demangling function but that is bitrotting as it is a copy of the msvcrt.__unDname . As i wanted to use the newer msvcrt.__unDname funtion i have written a quick and dirty program that is basicaly only a wrapper arou

Re: game "Knights and Merchants" deadlocks

2006-02-07 Thread Joris Huizer
Jesse Allen wrote: On 2/5/06, Joris Huizer <[EMAIL PROTECTED]> wrote: I'm running alsa with oss emulation - I think wine is using the oss interface (just ran winecfg, it says no audio driver is selected in registry, and it assumes it should run oss) And what sound module? (s

Re: Fwd: game "Knights and Merchants" deadlocks

2006-02-06 Thread Joris Huizer
I built valgrind 3.1.0 with the given patch, but for some reason valgrind fails to start the program correctly; I attached the log of a run; When I do not run with valgrind the program starts successfully. What is wrong? how should I get valgrind with the program running? Script started on Mon F

Re: game "Knights and Merchants" deadlocks

2006-02-05 Thread Joris Huizer
Jesse Allen wrote: On 2/4/06, Joris Huizer <[EMAIL PROTECTED]> wrote: If you could tell us your sound module name and which wine sound driver you use that could be helpful. There are a variety of sound problems out there. Jesse I'm running alsa with oss emulation - I think wi

Re: Fwd: game "Knights and Merchants" deadlocks

2006-02-04 Thread Joris Huizer
James Trotter wrote: On 2/4/06, *Joris Huizer* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote: Hello, I have this question: I have a game called "Knights and Merchants" which I sometimes play; I find it deadlocks each time after playing for an h

game "Knights and Merchants" deadlocks

2006-02-04 Thread Joris Huizer
Hello, I have this question: I have a game called "Knights and Merchants" which I sometimes play; I find it deadlocks each time after playing for an hour or so it seems it isn't a complete deadlock, sometimes some of sound comes through between intervals of minutes or so; harddisk activity se

Re: Benchmarks for 0.9.5

2006-01-20 Thread Joris Huizer
I'm a bit confused, how can there be failures under windows? is this because of driver problems? regards, Joris

Re: Accidentally fixed a bug :-)

2005-12-24 Thread Joris Huizer
Dan Kegel wrote: I've been helping a couple small ISVs test their apps and file bugs lately. To my surprise, one of the bugs (ChooseColor() not responding to keystrokes, http://bugs.winehq.org/show_bug.cgi?id=4125) was easy enough to fix without any real knowledge of the code, so I posted a patc

  1   2   >