Juan Lang pisze:
> Hi Mikolaj, this one was rejected due to formatting, I imagine because
> of C++ comments in the tests:
>
> +// Setting the same value will not set IsDirty...
>
> Would you mind fixing and resending? Thanks,
> --Juan
>
Yes, I've sent the old patch with C++ comments (and
David Hedberg pisze:
> I've also looked a bit at implementing support for IFileDialog, and
> the Explorer, but I have yet to dig too deep into either of them. Are
> there currently any known applications out there that uses IFileDialog
> explicitly? I've looked a bit, probably not enough, but I hav
2010/2/22 Dmitry Timoshkov :
> Mikołaj Zalewski wrote:
>
>> +/* strcmpW is avaiable for tests compiled under Wine, but not in standalone
>> + * builds under Windows, so we reimplement it under a different name. */
>> +static inline int winetest_strcmpW( const WCHAR
On Wed, Feb 10, 2010 at 9:32 PM, Nikolay Sivov wrote:
>
> On 2/10/2010 23:28, Austin English wrote:
>>
>> 2010/2/10 Mikołaj Zalewski:
>>
>>>
>>> Some installers require this.
>>>
>>
>> + expect_eq_x(S_FALSE, IPersistFile_IsDirt
If it does support Gregorian only there's nothing to worry about.
Actually I don't know how to test this, if we're talking about some
Asian locales like Chinese or Japanese are you experienced with that?
A best way will be to test under Linux with native comctl32 but I'm
not sure builtin ker
Hi,
I had little time to work on Wine lately, but recently I could work a
bit on my UUID database. The new version retrieves the identifier name
after __declspec(uuid) macros and is available as an online app on
AppEngine at http://mikolajapp.appspot.com/uuid/ .
The offline version with the
Nikolay Sivov pisze:
Hi.
Working on monthcal control I've realized that some locales could have
13 months calendars.
How could I guess that I'm running such locale? After a brief look I
didn't find anything useful
in GetLocaleInfo().
AFAIK the GetCalendarInfo() and EnumCalendarInfo() are for
The results for Wone 1.0.x
( http://pf128.krakow.sdi.tpnet.pl/wine-transl/ )
won't open (tryied several times yesterday and today)
The correct URL is http://www.mikolaj.zalewski.pl/wine-transl/1.0.x/ .
This can be fixed in config.php (I've forgotten to update the example
config in the sour
It's now online at http://source.winehq.org/transl/ and will be updated
every time there's a git push. Please let me know if you find any
problems. The source is also available now in the tools.git repository.
It looks like there is a problem with CSS - some formatting is gone
and I get a 4
If you send me the necessary information I can probably take care of it.
I've uploaded the lastest version to
http://www.mikolaj.zalewski.pl/dl/wine-transl.tgz . There is a README
there, but basically one needs to start with copying
scripts/config-example to scripts/config and setting the
Jonathan Ernst napisał(a):
Hello,
Le dimanche 07 décembre 2008 à 02:15 +0100, Mikołaj Zalewski a écrit :
Hi,
I didn't update the translation statistics
(http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my
Your server seems down. Wouldn't it be bett
Yes, handling the translation of Wine's resource files would be really
nice. It would let us leverage a lot of the po tools, especially the
website based ones. This would make it much easier for users to
contribute to the translations (right now it's pretty intimidating). I'm
not sure how to
Austin English wrote:
2009/4/16 Mikołaj Zalewski :
This version of the patch uses the now implemented GetProcessImageFileName.
From 549bdead0736d63bc2c05557b6813a64b53aa2ec Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Miko=C5=82aj_Zalewski?=
Date: Sun, 21 Dec 2008 22:28:32 +0100
Subject
Igor Tarasov wrote:
Hi!
I've found few visual glitches in comctl32/toolbar, and now try to
write this all down as conformance tests, but I have some problems. I
see that there is bug, when I test it with control spy. But when I
repeat it in testcase, it won't work. Here is how you can reproduce
Hi,
I think it would be interesting to test what TB_GETBUTTONINFO returns
as iString for such a separator. That way we will know if the value is
simply ignored, or it's something more complicated.
+static void test_deadbeef(void)
I think you should find a better name. Maybe test_addbutt
s way:
cd ~/.wine/drive_c/foo/bar
wine ../prog.exe
Start.exe won't help here, as I don't see any path-related options there.
Using:
wine start 'c:\windows\Start Menu\My App\App.lnk'
ususally does the trick. However, this can also be hard for a novice to
guess.
Mikołaj Zalewski
Anyway, e.g. Sib Icon Edit required ~ 30 Mb (something like 27 images *
13440 width * 24 height * sizeof(each pixel)) of memory for every instance
to run (due to this bug). Now it requires only about 300kb
Fixing one app doesn't mean it's correct. Yes, there is an obvious error in
the ima
Jérôme Gardou pisze:
> Let's rephrase it : most bug reporters expect the console log to be
> useful for developers willing to fix their problem :-)
Maybe I should have made it clear - I think that your patch, even in
the first version, was a step forward :).
As for the second patch, Alexandre
id this is what is done by the 1% best users ;). I'd expect
that a typical user to complain that Linux is broken because on Linux,
from time to time, apps just disappear from the screen while on Windows
they don't. Already knowing that there is such a thing like Wine
requires some knowledge :).
Mikołaj Zalewski
Alexandre Julliard wrote:
>If there is evidence that Windows really uses the reserved fields to
>store bHot and bDropDownPressed then the code should be using
>bReserved[0] and bReserved[1], wrapped with appropriate accessor
>functions if necessary. Otherwise they should be moved somewhere else
>a
Dmitry Timoshkov wrote:
> "Mikołaj Zalewski" wrote:
>
>>>> +/* Note: TOOLBAR_DumpButton assumes the layout of the beginning of
>>>> the structure
>>>> + * is the same as of TBBUTTON */
>>>> typedef struct
>>>> {
>&g
Dmitry Timoshkov wrote:
> "Mikolaj Zalewski" wrote:
>
>> +/* Note: TOOLBAR_DumpButton assumes the layout of the beginning of
>> the structure
>> + * is the same as of TBBUTTON */
>> typedef struct
>> {
>> INT iBitmap;
>> @@ -96,6 +98,9 @@ typedef struct
>> BYTE fsStyle;
>> BYTE bHo
Is there something wrong with this patch?
Hi,
I didn't update the translation statistics
(http://www.mikolaj.zalewski.pl/wine-transl/) very regularly lately - my
server is a bit broken and I can't run the scripts from cron but have
remember to do it manually from a different computer. I have plans to
fix it, but in the mean time, a
works.
BTW, as a reminder, you shouldn't use VS for msvcrt tests as you will
link to e.g. msvcr80.dll instead of msvcrt.dll.
Mikołaj Zalewski
wn/handled. Often, this will give
information what message caused a crash in Wine control code or what
notify caused a crash in application code.
Mikołaj Zalewski
As it was written, you need to write some more tests for such changes.
It required a few iterations before we got
SetWindowLongPtr(GWLP_WNDPROC, ...) right, so this might be also not
easy. The tests for SetWindowLongPtr are in dlls/user32/tests/class.c.
Some things I can think of that require
>You should not change scmdatabase_find_service_by_displayname, it does
>what its name implies. You should fix the callers where necessary.
>
>
The scmdatabase_find_service_by_displayname is currently wrong. It
dereferences a NULL pointer if the registry database contains a service
without a
to on http://pf128.krakow.sdi.tpnet.pl/uuid.tgz . It's
written in JavaScript and works under Firefox 1.5+ (it would require
some small modifications to work on IE).
Mikołaj Zalewski
not something that could be done before Wine 1.0.
Mikołaj Zalewski
I have filled the form but got error 404 after clicking "Request Trial
CD".
Mikołaj Zalewski
> Is this a wine bug or not?
It is a wine bug - the controls for such languages should be bigger.
Mikolaj Zalewski
s there should be
then you have probably encoded the file in UTF-8. Try to add '#pragma
code_page(65001)' at the top and '#pragma code_page(default)' at the
bottom of Bg.rc. By default wrc expects the string to be in the Windows
codepage for the specified language.
Mikołaj Zalewski
s?highlight=%28Developers%29#head-ef42a958e4f633dbd4a0ae42649fa02a4d1827fd
)
Mikołaj Zalewski
I think the release candidate phase for Wine 1.0 is a good time to add
new translations and it's also important to fix out-of-sync resources.
They may cause programs to run incorrectly when running under with a
different language (I've filled a bug about it:
http://bugs.winehq.org/show_bug.cg
ackground - the services are marked as system processes
and if there is no non-system process left, all the system processes
will terminate themselves.
Mikołaj Zalewski
008-March/051641.html
>...
>
>
For some reason the attachements are shown by the mail archive as
separate [PATCH] entries, like:
http://www.winehq.org/pipermail/wine-patches/2008-March/051639.html .
Mikołaj Zalewski
s a
chapter about it in "Windows Internals" by M. Russinovich and D. Solomon).
Mikołaj Zalewski
> If LoadLibrary is indeed needed it should be accompanied with a
> FreeLibrary and we probably need a comment for the why as well.
Does it matter if we call FreeLibrary on the library we are testing? I
don't think we will be able to free it before the end of the tests when
anyhow it will be
I've changed GetModuleHandle to LoadLibrary because when I compiled
only tests/rebar.c as standalone, the comctl32 wasn't loaded and
GetModuleHandle returned NULL. Are there advantages from using
GetModuleHandle?
Mikołaj Zalewski
was created earlier) what
caused it to appear to be disabled. I checked that in that installer the
groupbox had the BS_GROUPBOX style. Maybe that depends on some flags?
Mikołaj Zalewski
refcount of the whole subtree starting in this node. This is more
elegant but it would take a linear time with respect to the tree height
to update the refcount).
Mikołaj Zalewski
>
> I can pick a new coordinate to fix this, but then the new hit test
> will be just as brittle as the current one. Anyone have better ideas
> on how to make these coordinate based tests more robust?
>
For the toolbar tests I have been sending WM_SETFONT with
GetStockObject(SYSTEM_FONT) . It
Robert Shearman wrote:
> You might want to find four real components always present on Windows to
> add to this key.
>
From the keys present on my system I could add HTML Help, DirectDrawEx
and some two versions of .NET Framework but I didn't know if it wouldn't
interfere with some setup pr
Dmitry Timoshkov pisze:
"Mikolaj Zalewski" <[EMAIL PROTECTED]> wrote:
Then there is no point in using FreeType for loading font files at all,
(or adding support for new font file formats to FreeType) since
FreeType
can load fonts from memory.
Do you mean that in AddFontResource I shouldn't t
Then there is no point in using FreeType for loading font files at all,
(or adding support for new font file formats to FreeType) since FreeType
can load fonts from memory.
Do you mean that in AddFontResource I shouldn't try to call
WineEngAddFontResourceEx but do only a LoadLibraryEx (that wo
ionVector should not be filled for IE to install).
Mikołaj Zalewski
static const char classA[] = "deftest";
static const WCHAR classW[] = {'d','e','f','t','e','s','t',0};
+WCHAR unistring[] = {0x142, 0x40e, 0x3b4, 0}; /* a string that
would be destoryed by a W->A->W conversion */
Any other string should work just fine. In the current form the te
Alexandre Julliard wrote:
Mikołaj Zalewski <[EMAIL PROTECTED]> writes:
@@ -389,10 +390,10 @@ static void TOOLTIPS_GetDispInfoW(HWND hwnd,
TOOLTIPS_INFO *infoPtr, TTTOOL_INFO
sizeof(ttnmdi.szText)/sizeof(ttnmdi.szText[0]) : INFOTIPSIZE-1;
lstrcpynW(i
I think the best thing is for Wine
to support things like
LC_ALL="nn nb"
LANG="nn nb"
because even though we provide a Nynorsk translation, most programs will only
be available in Bokmål.
It seems that Vista supports many user preferred languages and many
system fallback languages so it s
I'm trying to write a tests for invalid cbSize in Shell_NotifyIcon.
The behaviour under Windows XP is to assume in such a case that the size
is NOTIFYICONDATA_V1_SIZE. AFAIK Shell_NotifyIcon doesn't provide a way
to read icon data to check that the data introduced after Win95 is not
modified.
Dmitry Timoshkov wrote:
"Mikolaj Zalewski" <[EMAIL PROTECTED]> wrote:
+/* The validation is also done in explorer. However we must also
do it
+ * on the client size so that WM_COPYDATA doesn't crash the
application
+ */
+if (nid->cbSize != NOTIFYICONDATAW_V1_SIZE &&
+
+#include "ui_Pl.rc"
You missed the translated File, but it would be nice,
when you wait a week please:
I have a Patch for AddPortUI, that add more strings and a Dialog
and the Patchs grow whith more translations.
I forgot the git add. But then I won't resend it but I'll wait for
Since it clearly sounds like a CopyImage bug it would be more appropriate
to fix CopyImage instead, Microsoft may do that at some point as well.
I was a bit affraid that even Windows Vista has this bug so there
might be apps depending on it. However it would be strange for some app
to depen
For my translations statistics
(http://pf128.krakow.sdi.tpnet.pl/wine-transl/) I use a patched wrc that
has a different output for "wrc --verify-translation". Could I send this
patch to wine-patches or is there someone other using "wrc
--verify-translation" and would be upset if the format cha
Paul Vriens wrote:
Hi,
Could anyone think of a reason that the netapi32 tests are not linked
with netapi32.dll although this is specified in the Makefile?
It looks like the tests doesn't call directly any function from
netapi32. In such a case the compiler can skip linking the DLL (e.g.
V
If you're testing what message is sent, why not use the message
sequence testing code?
That's true that a message sequence test would be better. I haven't
thought about it.
Mikolaj Zalewski
and get pointer pointing to
user32. Could you do:
printf("%p, %p, %p\n", DefWindowProcA, GetModuleHandle(NULL),
GetModuleHandle("user32"));
I get: 77D4D4EE, 0040, 77D4
Mikołaj Zalewski
Could it be that 6.0 only registers those controls listed using window
class dependencies in the manifest file? If what you say about 5.82 is
true your patch is correct though ofcourse.
I've checked both 5.82 and 6.0 (with a "standard" manifest) and both
registers all the classes. I don't k
The usual convention is that IDD_* are used for IDs of dialogs and
IDC_* are used for IDs of controls.
The Browse For Folders dialog uses IDD_ for controls and I wanted to
follow the convention in this file.
Mikolaj Zalewski
Dan Kegel wrote:
Mikołaj wrote:
I've tested it also with WinRAR, WinSCP3 3.30, 7-Zip and Pirch98 (the
last two have Bugzilla entries and are fixed by the new code). The only
thing I've found not to work are the sidebars of IE.
Did they work with the old code?
WinRAR did. Other had bigger o
Robert Shearman napisał(a):
Mikołaj Zalewski wrote:
I've been trying to fix the rebar layouting code. But fixes in one
place caused regressions because of bugs in other places and I ended
up rewriting the whole layouting code. It does roughly the same as
the current code however the de
This function is a bit ugly. It seems this policy should be made in
the BrsFolder_OnCommand function, rather than in pidl.c as a file.
Yes, after I've found _ILCreateDesktop there is no need for a helper
funciton. I'll send a patch without it.
Mikolaj Zalewski
Actually all members are always valid (for the internal structure at
least). I already sent a patch which removes the mask.
Felix
Sorry, I didn't notice the patch.
Mikolaj
@@ -329,8 +329,8 @@ static void test_delete(void)
static void test_rename(void)
{
SHFILEOPSTRUCTA shfo, shfo2;
-CHAR from[MAX_PATH];
-CHAR to[MAX_PATH];
+CHAR from[5*MAX_PATH];
+CHAR to[5*MAX_PATH];
DWORD retval;
shfo.hwnd = NULL;
This is really hacky. If th
AFAIK by default Windows XP enables the no-exec protection only for
"essential Windows programs and services". I couldn't find what that
means but it's described as if it is a fixed list of Windows system
binaries. The protection can enabled for all programs (except for a list
provided by the
Christoph Frick wrote:
He or she wants de; anything else would be like: ``there is no en_UK?
then lets use mongolian!``.
So it looks like SUBLANG_NEUTRAL is the best choice. I could make a
patch to modify all the sublang code in German files to SUBLANG_NEUTRAL.
Mikolaj Zalewski
Actually there's now some differences for the German and Austrian sublang
spellings of some words. I'm not sure how windows handles the new spelling
rules used in Germany now, though.
I admit I don't know how large are the differances between German and
Austrian spelling but as Frank Richt
As I wrote I've found that there is a mess in wine with the usage of
SUBLANG_NEUTRAL and SUBLANG_DEFAULT. I tried to understand when to use
which and wrote a wiki page about it:
http://wiki.winehq.org/SublangNeutral .
It contains some generic information about it but I thought that it
would b
the test could force the user backend (see the console test in
kernel32 directory)
I see - I haven't noticed that --use-event automatically chooses the
user backend.
Mikolaj Zalewski
It should make no differance for Korean is you use SUBLANG_NEUTRAL or
SUBLANG_DEFAULT as there is only one sublang.
SUBLANG_NEUTRAL is a fallback that is used if no translation is
available in the user's selected sublang. In can be used for locales
that have many sublangs (e.g. French have Fre
but your code doesn't release the selection on button up, which is
rather strange when you do only mouse selection
A+
I've checked it and currently the whole section is dead code as on
WM_LBUTTONUP the (wParam&MK_LBUTTON) is always false.
However if I remove this condition I think my code
did you check that this behavior is done for every mode of the console ?
A+
What do you mean by every mode?
Mikolaj Zalewski
as a principle, why do oppose keyboard selection to mouse selection
looks to me you could in principle do both... so any key except
return, arrow keys should end the selection
and you woun't need the extraneous mouse_selection
I wanted to make it in the same way as on Windows. But I think it
case WM_LBUTTONUP:
-if (data->curcfg.quick_edit)
+if (data->curcfg.quick_edit || PRIVATE(data)->has_selection)
{
if (GetCapture() == PRIVATE(data)->hWnd &&
PRIVATE(data)->has_selection &&
(wParam& MK_LBUTTON))
{
Alexandre Julliard wrote:
Mikołaj Zalewski <[EMAIL PROTECTED]> writes:
@@ -949,6 +954,12 @@ TrackMouseEvent (TRACKMOUSEEVENT *ptme)
}
}
} else {
+/* In our implementation it's possible that another window will
receive a
+ * WM_MOUSEMO
Why does winetest start programs with STARTUPINFO.wShowWindow =
SW_HIDE? I think this makes some of the toolbar tests fail as they
depend UpdateWindow sending a WM_PAINT (they fail when launched by
winetest but pass when running comctl32_test.exe from the command line).
Could I remove this lin
I am now inclined to think - and in line with what you say - that it would be
safer and more efficient to modify FillNumberFmt() to take two more arguments
and pass the buffer sizes in as well, i.e., in effect, its declaration should
be:
static void
FillNumberFmt(NUMBERFMTW *fmt, LPWSTR decimal
Andrew Talbot wrote:
I am about to submit another try, to see what people think. This time I'm
using GetLocaleInfoW() twice for each buffer: once, to determine the size
needed, and again, to actually get the locale info.
I'm afraid this is worse than it was - if a separator will happen to
b
Andrew Talbot wrote:
Dan Kegel wrote:
BTW the way you define the new size, as a magic constant, seems
bad. Can you use 4 * sizeof(WCHAR), or whatever, instead of 8?
And even then, the '4' seems almost as bad.
- Dan
Yes, I did feel uneasy about using a magic constant, I must admit. A
Nice one! I'll see if I can update some of the German resources.
One thing I noticed is that the message table in kernel32 is treated as
one resource in the statistics, although it contains quite a number of
strings itself. Maybe wmc can be augmented with some
"--verify-translation" equivalent
To check what needs to be translated I have played a bit with wrc
--verify-translation and made some HTML from it's results. As this
might interest other translators I've put the statistics at
http://pf128.krakow.sdi.tpnet.pl/wine-transl/ .
Very nice! It would be cool if we could integra
To check what needs to be translated I have played a bit with wrc
--verify-translation and made some HTML from it's results. As this might
interest other translators I've put the statistics at
http://pf128.krakow.sdi.tpnet.pl/wine-transl/ .
Mikolaj Zalewski
Maybe you've seen it already, but this blog post talks about the various
allocators: http://blogs.msdn.com/oldnewthing/archive/2004/07/05/173226.aspx
-f.r.
Yes, that's where I learned about it (a link to it is included in the
documentation of SHLoadOLE)
Mikolaj
+Applications
+
+Wine
+__HOME__/.wine/menu
+
+
Why are you hard-coding this path to being .wine? You correctly used
$WINEPREFIX before.
I've forgot about WINEPREFIX here but when I added it there is a
problem that wineprefixcreate is called with a directory lik
I was investigating the menu problems and now I'm back so I could try
to fix it. The problem is with the support for the new freedesktop.org
standard. In it the /usr/share/applications and
~/.local/share/applications contains a flat list of applications while
the menu structure is controlled b
I've sent patches to implement the trashing of files (starting from
http://www.winehq.org/pipermail/wine-patches/2006-July/028782.html ) and
they were rejected. Could someone tell me what's wrong with them?
Mikolaj Zalewski
Robert Shearman wrote:
I don't think it is. I think it would be better to start off with by
just doing the shell integration in shell32. If a framework like this
is needed, then it will become obvious later on.
That's true that I currently don't need it but if someones would need
a really t
I've changed the code not to use COM. Now it loads a DLL and searches
for a GetIntegrationObject entry point. That function returns structures
with a pointer to the ops structure. This is similar to how GDI objects
are implemented.
One could also export all the function from the DLL and build
The number of developers that understand COM aggregation and all the
baroque rules that make it up is very, very low. A simple ops struct of
function pointers as used in the wineserver or kernel would be fine here
... COM adds an awful lot of complexity that really isn't needed at all
(eg you mu
Alexandre Julliard wrote:
I think using COM for that sort of thing is overkill.
If we want to allow multiple implementations then using a structure with
callback functions is probably the easiest way. If we are using
structures with callback functions then why not to make it COM
interfaces -
I think the general approach is good.
The way you handle the built in implementation seems odd to me. I think
setting the registry key to make the freedesktop.org version as the default
would be good enough.
If we don't have built-in trash etc. objects then when we add a new
object we will
As a SoC project I'll try to improve the integration of wine with the
Unix shells. My first step will be to implement the freedesktop.org
Trash. I've written some code that doesn't add any new features but
shows how I want to add it. I'd like to know if this is a good design?
The main idea is
You will need to split this patch into two. Checking for NULL has nothing
to do with callback. Also I'm not sure why are you removing NULL check?
Any explanations, tests?
This patch is already split into eight parts - I hope thay are small
enough. That's true the first patch doesn't have mu
Segin wrote:
If this was to be done, there are a few things I suggest:
First should be everything that Freedesktop.org has laid out, and
nothing more. That does into the FD.org integration code. For a lot of
this to work, Wine may have to be ran as a system service (is that
even a good idea
I've had an idea for a SoC project and filled the application. In a
comment I was advised to discuss it on wine-devel.
The idea is to integrate the wine shell32 with the Linux desktops. The
main problem is of course that there are many desktop environments and
only some things are standardiz
The Drivers-Listview in winecfg works now (thanks for that fix), but the
Listview-Issues in winefile are still present.
Any Ideas?
I haven't noticed them but I'll try to look into them tomorrow.
Mikolaj Zalewski
97 matches
Mail list logo
