Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Rico Schüller
Am 09.11.2010 18:39, schrieb Henri Verbeet: 2010/11/9 Rico Schüller: I made the assumption, because setting the vtbl is the first thing d3dcompiler_shader_reflection_init() does. It is, but you're not supposed to care. Abstractions aren't very useful if you have to care about the deta

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Henri Verbeet
2010/11/9 Rico Schüller : > I made the assumption, because setting the vtbl is the first thing > d3dcompiler_shader_reflection_init() does. It is, but you're not supposed to care. Abstractions aren't very useful if you have to care about the details of their internals. > Well, a heap free isn't al

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Rico Schüller
Am 09.11.2010 12:01, schrieb Henri Verbeet: 2010/11/8 Rico Schüller: -object->vtbl =&d3dcompiler_shader_reflection_vtbl; -object->refcount = 1; +hr = d3dcompiler_shader_reflection_init(object, data, data_size, riid); +if (FAILED(hr)) +{ +WARN("Failed to initialize

Re: (try 2)[PATCH 1/4] d3dcompiler: Add initial reflection parsing.

2010-11-09 Thread Henri Verbeet
2010/11/8 Rico Schüller : > -object->vtbl = &d3dcompiler_shader_reflection_vtbl; > -object->refcount = 1; > +hr = d3dcompiler_shader_reflection_init(object, data, data_size, riid); > +if (FAILED(hr)) > +{ > +WARN("Failed to initialize shader reflection\n"); > +IU