Re: [2/7] shlwapi/tests: Add tests for StrStrA.

2010-07-19 Thread Andrew Nguyen
On 07/19/2010 11:01 AM, Detlef Riekenberg wrote: Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to

Re: [2/7] shlwapi/tests: Add tests for StrStrA.

2010-07-19 Thread Detlef Riekenberg
Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in you