Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 22:20:33 schrieb Henri Verbeet: > Sure, but unless you split up SFLAG_CONVERTED first, that flag is also > the same for RGB and sRGB. You've got a point here, I'll put the patch into my hack collection for now until I find something better. Probably we should put the per G

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/15 Stefan Dösinger : > Am Montag, 15. Juni 2009 16:19:22 schrieb Henri Verbeet: >> 2009/6/15 Stefan Dösinger : >> > In the current code, we don't do that, because only via ddraw.dll the use >> > of client storage can change, and only d3d9 can use sRGB textures. >> >> No, SFLAG_CLIENT only de

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 16:19:22 schrieb Henri Verbeet: > 2009/6/15 Stefan Dösinger : > > In the current code, we don't do that, because only via ddraw.dll the use > > of client storage can change, and only d3d9 can use sRGB textures. > > No, SFLAG_CLIENT only depends on the availability of the ex

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/15 Stefan Dösinger : > In the current code, we don't do that, because only via ddraw.dll the use of > client storage can change, and only d3d9 can use sRGB textures. No, SFLAG_CLIENT only depends on the availability of the extension, and other surface flags. Since neither of those will be di

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Stefan Dösinger
Am Montag, 15. Juni 2009 09:16:07 schrieb Henri Verbeet: > 2009/6/14 Stefan Dösinger : > > +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum > > internal, GLsizei width, GLsizei height, GLenum format, GLenum type, + > > DWORD client_store_fl

Re: [4/5] WineD3D: Manage SFLAG_CLIENT separately for RGB and SRGB textures

2009-06-15 Thread Henri Verbeet
2009/6/14 Stefan Dösinger : > +static void surface_allocate_surface(IWineD3DSurfaceImpl *This, GLenum > internal, GLsizei width, GLsizei height, GLenum format, GLenum type, > + DWORD client_store_flag) { I think that's ugly. More importantly, I don't see how cl