Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-04 Thread Henri Verbeet
2009/12/4 Stefan Dösinger : > hr = create_primary_opengl_context(iface, (IWineD3DSwapChain *) > swapchain); > +if(SUCCEEDED(hr)) > +{ > +swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > +} This should probably be part of create_primary_opengl_context()

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-03 Thread Stefan Dösinger
Am 03.12.2009 um 11:19 schrieb Henri Verbeet: > 2009/12/3 Stefan Dösinger : >> It matters when reading back an offscreen render target if FBOs are enabled, >> but FBO_blit is not supported. The readback function calls >> glReadBuffer(device->offscreenBuffer) in this case, and is correct to do s

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-03 Thread Henri Verbeet
2009/12/3 Stefan Dösinger : > Am 02.12.2009 um 22:10 schrieb Henri Verbeet: >> This change is probably correct, but note that if it matters you're >> probably doing something wrong. > It matters when reading back an offscreen render target if FBOs are enabled, > but FBO_blit is not supported. The

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-02 Thread Stefan Dösinger
Am 02.12.2009 um 22:10 schrieb Henri Verbeet: >> switch(wined3d_settings.offscreen_rendering_mode) { >> case ORM_FBO: >> +This->offscreenBuffer = GL_COLOR_ATTACHMENT0; > This change is probably correct, but note that if it matters you're > probably doing something wrong. It

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO

2009-12-02 Thread Henri Verbeet
2009/12/2 Stefan Dösinger : > @@ -1082,6 +1082,7 @@ static HRESULT WINAPI > IWineD3DDeviceImpl_CreateSwapChain(IWineD3DDevice *iface, > object->wineD3DDevice = This; > object->parent = parent; > object->ref = 1; > +object->render_to_fbo = FALSE; This is redundant, the field is a