Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 14:08:20 schrieb Henri Verbeet: > 2009/8/6 Stefan Dösinger : > > That's why I still think we should use behavior flags as a last resort, > > and use other problem specific ways where possible and reasonable. (an > > example for what's not reasonable: Clone the entire priv

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > That's why I still think we should use behavior flags as a last resort, and > use other problem specific ways where possible and reasonable. (an example > for what's not reasonable: Clone the entire private data code in ddraw to > avoid the AddRef - I clearly prefer a b

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 12:26:20 schrieb Henri Verbeet: > > Not really, we have a number of cases in ddraw already where the default > > value is overwritten(e.g. depth test at device creation), and there are > > many other differences beyond defaults. > > I'm not sure we should take ddraw as an

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > Am Thursday 06 August 2009 11:54:58 schrieb Henri Verbeet: >> Another advantage of the flags is that you have a reasonably >> centralised overview of differences between the different wined3d >> client libraries. > Not really, we have a number of cases in ddraw already

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 11:54:58 schrieb Henri Verbeet: > If done properly, miracles have nothing to do with it... The problem > with patch 4 is that you really want the initial value to change, but > instead you change it afterwards, and hope you caught all the cases. > Fortunately the tests s

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
2009/8/6 Stefan Dösinger : > Am Thursday 06 August 2009 09:35:12 schrieb Henri Verbeet: >> Aside from the fact that you can't know WineDirect3DCreate() failed >> because of a lack of OpenGL without looking at its implementation, I >> liked the create flags approach better. > Well, the WINED3DOK_NO3

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Stefan Dösinger
Am Thursday 06 August 2009 09:35:12 schrieb Henri Verbeet: > Aside from the fact that you can't know WineDirect3DCreate() failed > because of a lack of OpenGL without looking at its implementation, I > liked the create flags approach better. Well, the WINED3DOK_NO3D is intended to say "you got your

Re: [6/8] WineD3D: Return a different success value if D3D is not available

2009-08-06 Thread Henri Verbeet
Aside from the fact that you can't know WineDirect3DCreate() failed because of a lack of OpenGL without looking at its implementation, I liked the create flags approach better.