Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-10 Thread Alexandre Julliard
Eric Pouech writes: > Le 10/11/2010 22:32, Alexandre Julliard a écrit : >> Eric Pouech writes: >> >>> Le 10/11/2010 17:34, Alexandre Julliard a écrit : Eric Pouech writes: > msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does > Hence the wrappers inside msv

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-10 Thread Eric Pouech
Le 10/11/2010 22:32, Alexandre Julliard a écrit : Eric Pouech writes: Le 10/11/2010 17:34, Alexandre Julliard a écrit : Eric Pouech writes: msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you ha

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-10 Thread Alexandre Julliard
Eric Pouech writes: > Le 10/11/2010 17:34, Alexandre Julliard a écrit : >> Eric Pouech writes: >> >>> msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does >>> Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. >> Do you have an app that depends on this? >> > no

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-10 Thread Eric Pouech
Le 10/11/2010 17:34, Alexandre Julliard a écrit : Eric Pouech writes: msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you have an app that depends on this? no, just the current tests that fail A+

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-10 Thread Alexandre Julliard
Eric Pouech writes: > msvcr90 doesn't set msvcrt's errno in case of error, while msvcrt does > Hence the wrappers inside msvcr90 around _itoa_s and _itow_s calls. Do you have an app that depends on this? -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] [Msvcrt]: now using macro for parameters validation itoa_s (and updated the tests as well)

2010-11-09 Thread Eric Pouech
to sum up the recent discrepencies between msvcrt and msvcrN0 Dlls: - msvcrt doesn't raise exception on _s functions while msvcrN0 does - (likely) in _s functions returning an errno_t value, msvcrt does set errno to the returned value, while msvcrN0 doesn't change the errno value (tested on _itoa_s