Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-16 Thread Dmitry Timoshkov
Marcus Meissner wrote: > + unk = NULL; >hr = IDropTarget_QueryInterface(pDropTarget, &IID_IUnknown, (void**)&unk); >if(FAILED(hr)) >{ >IStream_Release(stream); >return hr; >} > + if (!unk) { > + WARN("hr was %d, but unk is NULL.\n", hr); > + IStream_Rel

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 12:40:46PM +0100, Huw Davies wrote: > On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote: > > On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > > > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > > > Marcus Meissner wrote: > >

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Huw Davies
On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote: > On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > > Marcus Meissner wrote: > > > > > > > + if (!unk) { > > > > + FIXME("hr was %d, but unk i

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > Marcus Meissner wrote: > > > > > + if (!unk) { > > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > > + return E_FAIL; > > > + } > > > > IDropTarget_

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Marcus Meissner
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > + if (!unk) { > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > + return E_FAIL; > > + } > > IDropTarget_QueryInterface() should be fixed instead. I am not sure where where the DropT

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Huw Davies
On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > + if (!unk) { > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > + return E_FAIL; > > + } > > IDropTarget_QueryInterface() should be fixed instead. The implementation is in abiword, s

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

2010-09-15 Thread Dmitry Timoshkov
Marcus Meissner wrote: > + if (!unk) { > + FIXME("hr was %d, but unk is NULL?\n", hr); > + return E_FAIL; > + } IDropTarget_QueryInterface() should be fixed instead. -- Dmitry.