Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 13:32, Stefan Dösinger wrote: > Is it ok to worry about this later and just remove > WINED3D_RESOURCE_ACCESS_SCRATCH for now? > Sure.

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 13:14, schrieb Henri Verbeet: > On 22 August 2013 13:07, Stefan Dösinger > wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> Am 2013-08-22 12:58, schrieb Henri Verbeet: >>> Yes, but if "pool" goes away we need some other way

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 13:07, Stefan Dösinger wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 2013-08-22 12:58, schrieb Henri Verbeet: >> Yes, but if "pool" goes away we need some other way to check for >> scratch resources. It's just that in retrospect the access flags >> probably aren

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 12:58, schrieb Henri Verbeet: > Yes, but if "pool" goes away we need some other way to check for > scratch resources. It's just that in retrospect the access flags > probably aren't the right place. If pool goes to d3d8/9, the checks sh

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 11:53, Stefan Dösinger wrote: > I think it's best to check the pool in operations that accept a > resource as parameter. We already do that in most places. Yes, but if "pool" goes away we need some other way to check for scratch resources. It's just that in retrospect the access

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 10:25, schrieb Henri Verbeet: > Yeah, I'm not particularly happy about it either. The issue is > that scratch resources allow some extra formats over sysmem > resources, but can't be used for resource uploads. The idea is to > eventually

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 09:58, Stefan Dösinger wrote: > What I'm not quite happy with is WINED3D_RESOURCE_ACCESS_SCRATCH. > Scratch resources are mappable. Having the extra location just > complicates things and I see no gain from it. > Yeah, I'm not particularly happy about it either. The issue is that

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-22 09:11, schrieb Henri Verbeet: > On 22 August 2013 00:30, Stefan Dösinger > wrote: >> +const char *wined3d_debug_location(DWORD location) +{ +char >> buf[238]; > That number looks a bit arbitrary, although I suppose it's at > least la

Re: [PATCH 5/5] wined3d: Implement basic volume location management

2013-08-22 Thread Henri Verbeet
On 22 August 2013 00:30, Stefan Dösinger wrote: > +const char *wined3d_debug_location(DWORD location) > +{ > +char buf[238]; That number looks a bit arbitrary, although I suppose it's at least large enough. > +if (volume->resource.pool == WINED3D_POOL_SYSTEM_MEM > +|| volume->