Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-28 Thread Vincent Pelletier
Le Friday 26 December 2008 22:35:18 Vincent Pelletier, vous avez écrit : > I'm not sure where to add it. I've added some line in > d3d9/tests/visual.c:pointsize_test (attached too). As I wrote that > test to succeed on wine and did not run it on any windows version, I > would be happy if someone co

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-27 Thread Vincent Pelletier
Le Friday 26 December 2008 22:35:18 Vincent Pelletier, vous avez écrit : > As I guess IWineD3DDeviceImpl_CreateTexture should then return a > failure code, I patched it and made the test give up if texture > allocation failed. (patch attached) Updated to test previous return code, instead of acces

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-26 Thread Vincent Pelletier
Woops, re-sending to list this time... On Wed, Dec 24, 2008 at 4:01 PM, Stefan Dösinger wrote: > I think henri sent a reply. He recommended to clamp the new pointsize > instead of leaving the old one set. Found it. Wasn't subscribed here at that time (only to -patches). New version of previous

RE: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-24 Thread Stefan Dösinger
q.org] On Behalf Of Vincent Pelletier > Sent: Tuesday, December 23, 2008 7:31 PM > To: wine-devel@winehq.org > Subject: [RFC] wined3d: Avoid triggering OPENGL errors when setting > point size > > (Resent, originally sent to -patches... Sorry) > > If WINED3DRS_POINTSCALEENABLE

[RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-23 Thread Vincent Pelletier
(Resent, originally sent to -patches... Sorry) If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is set to an invalid size, glPointSize will fail. This happens in "Black & White 2", causing log/stderr to be flooded with opengl errors. I'm not sure if this should be fix

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size

2008-12-22 Thread Henri Verbeet
2008/12/23 Vincent Pelletier : > If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is > set to an invalid size, glPointSize will fail. > This happens in "Black & White 2", causing log/stderr to be flooded with > opengl errors. > > I'm not sure if this should be fixed here,