Re: [wininet]add implementation of few more options - try5

2005-11-10 Thread Alexandre Julliard
Vijay Kiran Kamuju <[EMAIL PROTECTED]> writes: > Dimitry: > I will try a zillion times, to make my patches get thru ;) :P The more you send it, the less likely it is to get through. When I see the same patch more than 3 times I just stop looking at it, as it clearly indicates that the patch is no

Re: [wininet]add implementation of few more options - try5

2005-11-09 Thread Juan Lang
Hi Vijay, > You told me to cleanup if the connection fails, i could not understand > how to clean up. (snip) > Please suggest me how to improve the tests, i have removed the ok and > the cruft for if(hurl == 0x0) That's all I wanted :) Thanks for taking the time to improve your tests. > Could y

Re: [wininet]add implementation of few more options - try5

2005-11-09 Thread Vijay Kiran Kamuju
Juan: You told me to cleanup if the connection fails, i could not understand how to clean up. If you could suggest me an example to do a clean up, it would be gr8. I just copied some stuff from tests of http.c Please suggest me how to improve the tests, i have removed the ok and the cruft for if(h

Re: [wininet]add implementation of few more options - try5

2005-11-09 Thread Dmitry Timoshkov
"Vijay Kiran Kamuju" <[EMAIL PROTECTED]> wrote: > as previous implementation had some bugs use this version and > implements some suggestions > more tests to come > > ChangeLog > > Added implementation for INTERNET_OPTION_VERSION > Added implementation for INTERNET_OPTION_USE

Re: [wininet]add implementation of few more options - try5

2005-11-09 Thread Juan Lang
Hi Vijay, + hurl = InternetConnectA(hinet,"www.winehq.com",INTERNET_DEFAULT_HTTP_PORT,NULL,NULL,INTERNET_SERVICE_HTTP,0,0); + ok((hurl != 0x0),"InternetConnect Failed\n"); + + if( hurl == 0x0) + { + InternetCloseHandle(hurl); + InternetCloseHandle(hinet); + return; + } The ok a