Re: Please review: Patch for non-Linux serial set_baud_rate()

2010-07-04 Thread Eric Pouech
Le 30/06/2010 20:26, Ken Thomases a écrit : On Jun 30, 2010, at 11:47 AM, Ken Thomases wrote: I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I

Re: Please review: Patch for non-Linux serial set_baud_rate()

2010-06-30 Thread Ken Thomases
On Jun 30, 2010, at 11:47 AM, Ken Thomases wrote: > I happened to stumble across some code which didn't look quite right in > dlls/ntdll/serial.c. However, I have no expertise in serial comms or > termios. Also, I have no means to test the change I propose. On the other > hand, the change se

Please review: Patch for non-Linux serial set_baud_rate()

2010-06-30 Thread Ken Thomases
Hi, I happened to stumble across some code which didn't look quite right in dlls/ntdll/serial.c. However, I have no expertise in serial comms or termios. Also, I have no means to test the change I propose. On the other hand, the change seems clearly right and conforms to what I learn from ma