Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 8:33 PM, Ben Klein wrote: > 2009/6/15 Mike Kaplinskiy : >> On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger >> wrote: >>> *) If  we create a stub / thunk driver for each known windows display >>> driver, >>> we potentially have  all those thunks around. E.g. an app might c

Re: Request for comments on patch

2009-06-14 Thread Ben Klein
2009/6/15 Mike Kaplinskiy : > On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger > wrote: >> *) If  we create a stub / thunk driver for each known windows display driver, >> we potentially have  all those thunks around. E.g. an app might complain that >> it finds BOTH nv4_disp.dll AND atiumdag.dll.

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:33 PM, Stefan Dösinger wrote: > *) If we create a stub / thunk driver for each known windows display driver, > we potentially have all those thunks around. E.g. an app might complain that > it finds BOTH nv4_disp.dll AND atiumdag.dll. > > *) Providing these vendor specif

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
Does the attached sound more like what people are looking for (with driver_filename_table filled in a bit more, of course)? Erich Hoover ehoo...@mines.edu From f731547eed5aef1cfcddc58a4da1e714ddd47d1f Mon Sep 17 00:00:00 2001 From: Erich Hoover Date: Sun, 14 Jun 2009 17:04:59 -0600 Subject: Repor

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:33 PM, Stefan Dösinger wrote: > Am Sonntag, 14. Juni 2009 23:11:42 schrieb Erich Hoover: > >> So, a patch similar to the one Mike pointed out* but able to report >> different drivers for different OSes would prove acceptable (possibly >> w/ a second patch for overrides)?  

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 11:44 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 3:33 PM, Mike > Kaplinskiy wrote: >> ... >> >> I didn't mean symlinking to the /lib/wine directory, but rather, >> symlinking to prefix/windows/system32/ from /lib/wine/ . But since >> that isn't done either, just copyi

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:33 PM, Mike Kaplinskiy wrote: > ... > > I didn't mean symlinking to the /lib/wine directory, but rather, > symlinking to prefix/windows/system32/ from /lib/wine/ . But since > that isn't done either, just copying to a new filename also seems > reasonable. Sadly if we do ha

Re: Request for comments on patch

2009-06-14 Thread Stefan Dösinger
Am Sonntag, 14. Juni 2009 23:11:42 schrieb Erich Hoover: > So, a patch similar to the one Mike pointed out* but able to report > different drivers for different OSes would prove acceptable (possibly > w/ a second patch for overrides)? The email was some time ago, but I > thought someone was prett

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 5:20 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 3:13 PM, Mike > Kaplinskiy wrote: >> ... >> >> Then perhaps when this mechanism is in place, we can add a way to have >> 1 general "funnel" dll and symlink it on prefix creation (if it's not >> already there). This way w

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 3:13 PM, Mike Kaplinskiy wrote: > ... > > Then perhaps when this mechanism is in place, we can add a way to have > 1 general "funnel" dll and symlink it on prefix creation (if it's not > already there). This way we don't have to worry about newer graphics > cards as much, an

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
On Sun, Jun 14, 2009 at 4:55 PM, Roderick Colenbrander wrote: > On Sun, Jun 14, 2009 at 10:52 PM, Roderick > Colenbrander wrote: >> On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: >>> On Sun, Jun 14, 2009 at 2:26 PM, Mike >>> Kaplinskiy wrote: I don't know about stubbing drivers, but I r

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 2:55 PM, Roderick Colenbrander wrote: > ... > > I forgot to mention the reason why previous registry key options > didn't enter Wine. The reason was that we had to have a good default > mechanism (e.g. returning nv4_disp.dll for nvidia by default on 2k/xp) > before adding ov

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 10:52 PM, Roderick Colenbrander wrote: > On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: >> On Sun, Jun 14, 2009 at 2:26 PM, Mike >> Kaplinskiy wrote: >>> I don't know about stubbing drivers, but I remember that >>> autodetection/registry wasn't accepted on the fallout

Re: Request for comments on patch

2009-06-14 Thread Roderick Colenbrander
On Sun, Jun 14, 2009 at 10:45 PM, Erich Hoover wrote: > On Sun, Jun 14, 2009 at 2:26 PM, Mike > Kaplinskiy wrote: >> I don't know about stubbing drivers, but I remember that >> autodetection/registry wasn't accepted on the fallout 3 patch. I think >> AJ would prefer something like >> http://source.

Re: Request for comments on patch

2009-06-14 Thread Erich Hoover
On Sun, Jun 14, 2009 at 2:26 PM, Mike Kaplinskiy wrote: > I don't know about stubbing drivers, but I remember that > autodetection/registry wasn't accepted on the fallout 3 patch. I think > AJ would prefer something like > http://source.winehq.org/git/wine.git/?a=commit;h=f2e2e3e49947490368900ef06a

Re: Request for comments on patch

2009-06-14 Thread Mike Kaplinskiy
I don't know about stubbing drivers, but I remember that autodetection/registry wasn't accepted on the fallout 3 patch. I think AJ would prefer something like http://source.winehq.org/git/wine.git/?a=commit;h=f2e2e3e49947490368900ef06a92e1df1bc52820 but for driver dll strings. But take my comments

Request for comments on patch

2009-06-14 Thread Erich Hoover
In an effort to come up with a (hopefully palatable) solution to a couple of bugs I've put together the attached patch.  Only the first of the two issues is currently handled, though the patch paves the way for the second issue. 1) Bug #15839: (not this title) Wine does not report the manufacturer