Hi,
I would suggest to keep the ones in pin.c. The file pin.c is a kind of
"template" collection.
Christian
Maarten Lankhorst a écrit :
> Hi Andrew,
>
> Andrew Talbot schreef:
>
>> It appears that the following vtables and Wine debug channels are not being
>> used, so I am considering remov
Andrew Talbot a écrit :
> Christian Costa wrote:
>
>
>> Hi Andrew,
>>
>> BTW, if the vtable are removed, there may be some unused functions. Will
>> they be removed as well ?
>>
>> Bye,
>> Christian
>>
>
> Hi Christian,
>
> Because I was mindful not to remove such things lightly, that is wh
Christian Costa wrote:
> Hi Andrew,
>
> BTW, if the vtable are removed, there may be some unused functions. Will
> they be removed as well ?
>
> Bye,
> Christian
Hi Christian,
Because I was mindful not to remove such things lightly, that is why I
sought feedback from the community, and I shall
Hi Andrew,
BTW, if the vtable are removed, there may be some unused functions. Will they
be removed as well ?
Bye,
Christian
> Message du 16/12/08 11:11
> De : "Maarten Lankhorst"
> A : "Andrew Talbot"
> Copie à : wine-devel@winehq.org
> Objet : Re
Hi Andrew,
Andrew Talbot schreef:
> It appears that the following vtables and Wine debug channels are not being
> used, so I am considering removing them. Please let me know, therefore, if
> you have plans for any of them and want them kept.
>
>
> Vtables:
>
> MemInputPin_Vtbl
Ken Thomases wrote:
> On Dec 15, 2008, at 3:41 PM, Andrew Talbot wrote:
>
>> It appears that the following vtables and Wine debug channels are
>> not being used, so I am considering removing them. Please let me
>> know, therefore, if you have plans for any of them and want them kept.
>>
>>
>> Win
On Dec 15, 2008, at 3:41 PM, Andrew Talbot wrote:
> It appears that the following vtables and Wine debug channels are
> not being used, so I am considering removing them. Please let me
> know, therefore, if you have plans for any of them and want them kept.
>
>
> Wine debug channels in:
>
> [.
On Mon, Dec 15, 2008 at 3:36 PM, Henri Verbeet wrote:
> 2008/12/15 James Hawkins :
>> Why would you remove any of them? That's like removing stub functions
>> because we don't know if they're ever called.
>>
> Although it probably doesn't make sense to remove these if people have
> plans for them
2008/12/15 Austin English :
> The same argument would apply to the debug channels. They don't hurt
> anything, and when needed, are easier to use if already in place.
>
> What do you gain by removing them?
>
It doesn't work that way. The question should be if you can justify
keeping a piece of code
2008/12/15 James Hawkins :
> Why would you remove any of them? That's like removing stub functions
> because we don't know if they're ever called.
>
Although it probably doesn't make sense to remove these if people have
plans for them, I do think that in general you shouldn't add code
until it's a
On Mon, Dec 15, 2008 at 4:52 PM, Andrew Talbot
wrote:
> James Hawkins wrote:
>
>>
>> Why would you remove any of them? That's like removing stub functions
>> because we don't know if they're ever called.
>>
>
> OK. I get the message; I shall leave the vtables alone. May I take out the
> unused de
James Hawkins wrote:
>
> Why would you remove any of them? That's like removing stub functions
> because we don't know if they're ever called.
>
OK. I get the message; I shall leave the vtables alone. May I take out the
unused debug channels, though? I presume they can easily be re-introduced
I Agree.
There was also this can of cleanup in d3dxof and direct music dlls
whereas there are not complete.
Some code are put in place as placeholder for future developments in one
hand and there is some clean-up to remove them in the other.
I don't see the point.
Christian
James Hawkins a écr
2008/12/15 Andrew Talbot :
> secur32/schannel.c
This one isn't unused, but all its uses are inside an #ifdef.
On Mon, Dec 15, 2008 at 1:41 PM, Andrew Talbot
wrote:
> It appears that the following vtables and Wine debug channels are not being
> used, so I am considering removing them. Please let me know, therefore, if
> you have plans for any of them and want them kept.
>
>
Why would you remove any of t
It appears that the following vtables and Wine debug channels are not being
used, so I am considering removing them. Please let me know, therefore, if you
have plans for any of them and want them kept.
Vtables:
IDirectXFileBinary_Vtbl d3dxof/d3dxof.c
IDirectXFileObject_Vtbl
16 matches
Mail list logo
