Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Jesse Allen
On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() > which causes snprintf() to write beyond the end of the buffer. > > I've attached a patch that fixes it for me, but it's probably better not > to create such large buffe

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Jesse Allen
On 4/17/06, Jesse Allen <[EMAIL PROTECTED]> wrote: > On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > > Jesse Allen wrote: > > > On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > > >> Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() > > >> which causes snprintf(

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Tomas Carnecky
Jesse Allen wrote: > On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: >> Jesse Allen wrote: >>> On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() which causes snprintf() to write beyond the end of the buffer

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Jesse Allen
On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > Jesse Allen wrote: > > On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > >> Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() > >> which causes snprintf() to write beyond the end of the buffer. > >> > >> I've attac

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Tomas Carnecky
Jesse Allen wrote: > On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: >> Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() >> which causes snprintf() to write beyond the end of the buffer. >> >> I've attached a patch that fixes it for me, but it's probably better not >>

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Jesse Allen
On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: > Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() > which causes snprintf() to write beyond the end of the buffer. > > I've attached a patch that fixes it for me, but it's probably better not > to create such large buffe

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Tomas Carnecky
Wine doesn't crash in this function, sorry, it's a bug in pf_vsnprintf() which causes snprintf() to write beyond the end of the buffer. I've attached a patch that fixes it for me, but it's probably better not to create such large buffers on the stack. Anyone with a better fix? tom diff --git a/dl

Re: WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Vijay Kiran Kamuju
Hi,I think it trys to map the charector to the built-in ctable charector based on the locale.This function belongs to libwineunicode, ask Alexander for more info.Thanks and regards,Vijay On 4/17/06, Tomas Carnecky <[EMAIL PROTECTED]> wrote: These circumstances being if it tries to load an invalid l

WoW crashes in 'wine_cp_mbstowcs' under certain circumstances.

2006-04-17 Thread Tomas Carnecky
These circumstances being if it tries to load an invalid lua file, more specifically a lua file which contains the invalid lua string (not character!) "\342\200\260". I don't know what this function does and there isn't a TRACE() in that function, so could someone please review if the function is