Re: mscoree: Attempt to load the assembly from the application directory (try 2)

2013-08-21 Thread Vincent Povirk
+/* Assume the namespace is the Assembly name */ Uh, what? We should only be passing an assembly name to get_file_from_strongname, not the class name. You shouldn't even have access to the class name. I think what you're actually doing here is skipping the assembly name and using the

Re: mscoree: Attempt to load the assembly from the application directory

2013-08-15 Thread Alistair Leslie-Hughes
On 15/08/2013 2:41 AM, Vincent Povirk wrote: This seems suspicious to me. You appear to be taking the namespace of the class and assuming it's an assembly name. Is there really no other information in the registry that could be used to identify the assembly? I'll have another look to see if it

Re: mscoree: Attempt to load the assembly from the application directory

2013-08-14 Thread Vincent Povirk
On Wed, Aug 14, 2013 at 4:04 PM, Daniel Jeliński wrote: > That being said, I think this is the wrong place for this change. Method > get_file_from_strongname [1] is better suited for that purpose IMO. Doing it that way is probably more correct, but it's also more dangerous because it would affect

Re: mscoree: Attempt to load the assembly from the application directory

2013-08-14 Thread Vincent Povirk
If we have the assembly name, then we should be using that to decide on the filename to try in the application directory, not the namespace.

Re: mscoree: Attempt to load the assembly from the application directory

2013-08-14 Thread Daniel Jeliński
Hi Vincent, there's no more info in the registry. At this point we have the assembly name and we know that it is not in GAC, so either it is in current directory or it's absent. That being said, I think this is the wrong place for this change. Method get_file_from_strongname [1] is better suited f

Re: mscoree: Attempt to load the assembly from the application directory

2013-08-14 Thread Vincent Povirk
This seems suspicious to me. You appear to be taking the namespace of the class and assuming it's an assembly name. Is there really no other information in the registry that could be used to identify the assembly?