Re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-12 Thread Álvaro Nieto
Thank you for your feedback. I'll adjust the tests with your comments and I'll try to use testbot. 2013/8/8 Dan Kegel > Minor problem: > > +static void test_strncpy(void) > +{ > +size_t len = 10; > +char *ret; > +char dst[len + 1]; > > Hmm. That last line is a VLA, and might not co

re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Dan Kegel
Minor problem: +static void test_strncpy(void) +{ +size_t len = 10; +char *ret; +char dst[len + 1]; Hmm. That last line is a VLA, and might not compile in all C compilers because it's not allowed in C89. http://stackoverflow.com/questions/448844/variable-sized-arrays-in-c Wine seems

Re: msvcrt: strncpy doesn't compliant C standard (try 3)

2013-08-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26638 Your paranoid android

Re: msvcrt: strncpy doesn't compliant C standard (try 2)

2013-08-07 Thread Frédéric Delanoy
On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto wrote: > Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy

Re: msvcrt: strncpy doesn't compliant C standard

2013-08-06 Thread Nikolay Sivov
On 8/6/2013 11:09, Álvaro Nieto wrote: This patch solves [Bug 34211]. The implementation of strncpy function doesn't compliant with C standard [1]. Also Microsoft Visual Studio C/C++ compiler is ok with the standard [2]. Extract from msdn; "The strncpy function copies the initial count charac