Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-11 Thread Ken Thomases
On Apr 11, 2013, at 8:49 AM, Jacek Caban wrote: > On 04/10/13 16:16, Ken Thomases wrote: >> However, Apple's guidance on using weak linking says that you must >> explicitly compare against NULL. They don't quite say that testing the >> symbol as a standalone boolean expression won't work, but t

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-11 Thread Jacek Caban
Hi Ken, On 04/10/13 16:16, Ken Thomases wrote: > Hi Jacek, > > On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote: > >> On 3/28/13 8:31 PM, Ken Thomases wrote: >>> Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. >> Can someone with Mac OS X 10.8 test the attached patch for me, please. All I >>

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-10 Thread Ken Thomases
Hi Jacek, On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote: > On 3/28/13 8:31 PM, Ken Thomases wrote: >> Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. > > Can someone with Mac OS X 10.8 test the attached patch for me, please. All I > need is to verify that it compiles and when running >

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-04-10 Thread Jacek Caban
On 3/28/13 8:31 PM, Ken Thomases wrote: Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. Can someone with Mac OS X 10.8 test the attached patch for me, please. All I need is to verify that it compiles and when running dlls/secur32/tests/secur32_test.exe.so schannel, TLS 1.1 and TLS 1.2 a

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-30 Thread Juan Lang
Hi Jacek, On Sat, Mar 30, 2013 at 8:36 AM, Jacek Caban wrote: > Most of the argument could be used against enabling TLS 1.1 and TLS 1.2, > because it's not present on older Macs (nor enabled by default on Windows), > so we'll have different behaviour. That's sadly something we have to live > wi

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-30 Thread Jacek Caban
Hi Juan, On 03/29/13 18:19, Juan Lang wrote: > Hi Jacek, > > thanks for the detailed reply. > > On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban > wrote: > > Each protocol has two kinds of enable/disable flags: "enabled" and > "disabled by default". Those have di

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-29 Thread Juan Lang
Hi Jacek, thanks for the detailed reply. On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban wrote: > Each protocol has two kinds of enable/disable flags: "enabled" and > "disabled by default". Those have different default values for each > protocol and there are registry setting allowing to change e

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-29 Thread Jacek Caban
Hi Juan, On 03/28/13 21:55, Juan Lang wrote: > On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases > wrote: > > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > > > --- a/dlls/secur32/schannel_macosx.c > > +++ b/dlls/secur32/schannel_macosx.c > > @@ -630,6

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-29 Thread Jacek Caban
Hi Ken, On 03/28/13 20:31, Ken Thomases wrote: > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > >> --- a/dlls/secur32/schannel_macosx.c >> +++ b/dlls/secur32/schannel_macosx.c >> @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef >> transport, const void *buff, >> re

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-28 Thread Juan Lang
On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases wrote: > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > > > --- a/dlls/secur32/schannel_macosx.c > > +++ b/dlls/secur32/schannel_macosx.c > > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef > transport, const void *buff, >

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

2013-03-28 Thread Ken Thomases
On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > --- a/dlls/secur32/schannel_macosx.c > +++ b/dlls/secur32/schannel_macosx.c > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef > transport, const void *buff, > return ret; > } > > +DWORD schan_imp_enabled_protocols(