Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-25 Thread Jacek Caban
Hi Hans, Sorry for the delay, I wanted to test it a bit more before answering. On 09/23/13 10:50, Hans Leidekker wrote: > On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: >> I was hoping for a test like the attached one, which shows that there is >> still more work to do. But it's a step in

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-23 Thread Hans Leidekker
On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: > I was hoping for a test like the attached one, which shows that there is > still more work to do. But it's a step in the right direction, so I'm > fine with your patch. The issue here is that HTTP_ReceiveRequestData calls refill_read_buffer,

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2255 Your paranoid andr

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-19 Thread Jacek Caban
Hi Hans, On 09/18/13 13:40, Hans Leidekker wrote: > diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c > index bf57223..2526681 100644 > --- a/dlls/wininet/tests/http.c > +++ b/dlls/wininet/tests/http.c > @@ -4777,8 +4777,37 @@ static const struct notification > async_send_request

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
On 09/11/13 17:32, Hans Leidekker wrote: > On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: >> Hi Hans, >> >> On 09/11/13 13:50, Hans Leidekker wrote: >>> static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t >>> *req) >>> { >>> -/* Allow reading only from read buffe

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: > > Network traces tell me that native also performs a read on the first call to > > InternetQueryDataAvailable. > > Are you sure it's not an asynchronous read from a separated thread that > is ordered by InternetQueryDataAvailable if no data is

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
On 9/11/13 7:09 PM, Hans Leidekker wrote: On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is ordered by Internet

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Hans Leidekker
On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: > Hi Hans, > > On 09/11/13 13:50, Hans Leidekker wrote: > > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t > > *req) > > { > > -/* Allow reading only from read buffer */ > > +chunked_stream_t *chunked_strea

Re: wininet: Don't assume that end of chunk means end of stream.

2013-09-11 Thread Jacek Caban
Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t > *req) > { > -/* Allow reading only from read buffer */ > +chunked_stream_t *chunked_stream = (chunked_stream_t*)stream; > +DWORD res; > + > +if(!chunke