Hi,
On Tue, Nov 01, 2005 at 12:47:15PM +0100, Marcus Meissner wrote:
> On Tue, Nov 01, 2005 at 12:35:00PM +0100, Andreas Mohr wrote:
> > ChangeLog:
> > Replace all Wine instances of doing a strlen() on a string literal
> > by its equivalent but much less onerous sizeof() - 1.
>
> Please just keep
On Tue, Nov 01, 2005 at 12:35:00PM +0100, Andreas Mohr wrote:
> Hi,
>
> On Fri, Oct 28, 2005 at 09:48:08AM -0700, Juan Lang wrote:
> > Hi James,
> >
> > +/* max port num is 655936 => 6 digits */
> >
> > Actually, it's 65535. A correct comment would be appreciated ;)
> >
> > +*lpdwUrlLength
On 10/28/05, Juan Lang <[EMAIL PROTECTED]> wrote:
>
> Right, and that's why I say, the comment is wrong. 655936 is too large
> for a WORD, and so is 65536, which I believe you meant to type. The
> correct value is 65535.
>
Oops. You are correct. Sorry for being stubborn about that point. I
gu
> > +/* max port num is 655936 => 6 digits */
> >
> > Actually, it's 65535. A correct comment would be appreciated ;)
> >
>
> InternetCreateUrl doesn't check whether it's a valid port number or
> not. The comment is about the maximum value for the port number in
> the context of InternetCreateUr
On 10/28/05, Juan Lang <[EMAIL PROTECTED]> wrote:
> Hi James,
>
> +/* max port num is 655936 => 6 digits */
>
> Actually, it's 65535. A correct comment would be appreciated ;)
>
InternetCreateUrl doesn't check whether it's a valid port number or
not. The comment is about the maximum value for th
On Fri, 28 Oct 2005 18:48:08 +0200, Juan Lang <[EMAIL PROTECTED]> wrote:
Hi James,
+/* max port num is 655936 => 6 digits */
Actually, it's 65535. A correct comment would be appreciated ;)
+*lpdwUrlLength += strlen("://");
You should use sizeof instead to avoid the call to strlen. Same
Hi James,
+/* max port num is 655936 => 6 digits */
Actually, it's 65535. A correct comment would be appreciated ;)
+*lpdwUrlLength += strlen("://");
You should use sizeof instead to avoid the call to strlen. Same for other
lengths you use, like "@" and ":".
+if (lpUrlComponents->nPo
