Re: wmvcore: Stub implementation of IWMMetadataEditor interface

2013-10-10 Thread Nikolay Sivov
On 10/10/2013 14:58, Jeff Latimer wrote: --- dlls/wmvcore/Makefile.in| 2 +- dlls/wmvcore/wmvcore_main.c | 100 +++- include/wmsdkidl.idl| 11 ++--- 3 files changed, 105 insertions(+), 8 deletions(-) +typedef struct MetadataEditorImpl {

Re: [2/2] wmvcore: Stub implementation of IWMMetadataEditor interface (try2)

2013-03-11 Thread Nikolay Sivov
On 3/11/2013 16:36, Jeff Latimer wrote: +if (!ppv) return E_INVALIDARG; You don't need this most likely. +IUnknown_AddRef((IUnknown*)*ppv); A cleaner way is to AddRef original iface, but that's a matter of taste. +static ULONG WINAPI WMCreateEditor_AddRef(IWMMetadataEditor *iface) +