Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >>> You mean removing protocol.c and adding all content to socket.c? If >>> yes I would appreciate if you could do that because I don't have the >>> git skills and wouldn't now how to sort the f

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >> You mean removing protocol.c and adding all content to socket.c? If >> yes I would appreciate if you could do that because I don't have the >> git skills and wouldn't now how to sort the functions inside socket.c. > It's not that hard. Just c

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 12:37 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:57 PM, Charles Davis wrote: > > On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > >> On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: You mean removing protocol.c and adding all content to socket.c? If yes I would appreciate if you could do that because I don

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard >>> wrote: Bruno Jesus <00cp...@gmail.com> writes:

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard >> wrote: >>> Bruno Jesus <00cp...@gmail.com> writes: >>> try 2: Narrow the loop for the specified protocol Add a

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: > On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> try 2: >>> Narrow the loop for the specified protocol >>> Add a new test for invalid sockets >> >> Considering wha

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> try 2: >> Narrow the loop for the specified protocol >> Add a new test for invalid sockets > > Considering what WSAEnumProtocols does, the loop doesn't seem necessary > at all. It will when WS

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > try 2: > Narrow the loop for the specified protocol > Add a new test for invalid sockets Considering what WSAEnumProtocols does, the loop doesn't seem necessary at all. -- Alexandre Julliard julli...@winehq.org

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1970 Your paranoid andr