Re: [Wireshark-dev] RTP-MIDI strange field masks?

2021-07-08 Thread Martin Mathieson via Wireshark-dev
Thanks, I clearly didn't read the line I quoted properly.. On Thu, 8 Jul 2021, 19:46 Tomasz Moń, wrote: > On Thursday, July 8, 2021, Martin Mathieson via Wireshark-dev < > wireshark-dev@wireshark.org> wrote: > >> These mask fields (0x7f7f, 0x7f7f7f7f, etc) look wrong to me, but I am >> worried I

Re: [Wireshark-dev] RTP-MIDI strange field masks?

2021-07-08 Thread Tomasz Moń
On Thursday, July 8, 2021, Martin Mathieson via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > These mask fields (0x7f7f, 0x7f7f7f7f, etc) look wrong to me, but I am > worried I might be missing something? > Seems perfectly fine to me. This dates back to MIDI over serial line where the mos

Re: [Wireshark-dev] RTP-MIDI strange field masks?

2021-07-08 Thread Evan Huus
I haven’t actually looked at the code, so it’s possible we’re doing the masking but not actually combining the bits into a single 14-bit value properly still. I wouldn’t expect a simple mask value to accomplish that. Evan On Thu, Jul 8, 2021 at 14:32 Evan Huus wrote: > Based on the 0xxx of

Re: [Wireshark-dev] RTP-MIDI strange field masks?

2021-07-08 Thread Evan Huus
Based on the 0xxx of your example and references like [1], I believe the masks are correct. MIDI seems to mostly use seven bit bytes schmucked together for some reason, so ignoring the high bit of each byte seems correct to me. Evan [1] http://midi.teragonaudio.com/tech/midispec/wheel.htm On

[Wireshark-dev] RTP-MIDI strange field masks?

2021-07-08 Thread Martin Mathieson via Wireshark-dev
These mask fields (0x7f7f, 0x7f7f7f7f, etc) look wrong to me, but I am worried I might be missing something? Looking at an example in RFC 4695 (Song Position Pointer) I think this (on page 157) is saying that is it just a 2-byte field (and should therefore have a non-mask of 0x0)? | Song Position