[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736088#comment-15736088 ] Wangda Tan commented on YARN-4390: -- +1, thanks [~eepayne] > Do surgical preemption based

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736080#comment-15736080 ] Eric Payne commented on YARN-4390: -- {quote} bq. the patch LGTM except the javac warning: g

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733600#comment-15733600 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730161#comment-15730161 ] Wangda Tan commented on YARN-4390: -- Hi [~eepayne], Thanks for update, the patch LGTM exce

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729021#comment-15729021 ] Eric Payne commented on YARN-4390: -- Unit tests TestAMAuthorization, TestCapacitySchedulerS

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15727160#comment-15727160 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726731#comment-15726731 ] Wangda Tan commented on YARN-4390: -- [~eepayne], thanks. Reopened the ticket to trigger Jen

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726446#comment-15726446 ] Wangda Tan commented on YARN-4390: -- Thanks [~eepayne], if the {{TestCapacitySchedulerSurgi

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725959#comment-15725959 ] Eric Payne commented on YARN-4390: -- The failing unit tests {{TestAMAuthorization, TestCapa

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723998#comment-15723998 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723497#comment-15723497 ] Wangda Tan commented on YARN-4390: -- Thanks, once you have the patch ready, I can help with

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723438#comment-15723438 ] Eric Payne commented on YARN-4390: -- Thanks [~leftnoteasy]. I think I have it figured out.

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716142#comment-15716142 ] Wangda Tan commented on YARN-4390: -- [~eepayne], yeah I think YARN-4865 is required. Apolo

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715787#comment-15715787 ] Eric Payne commented on YARN-4390: -- [~leftnoteasy], It looks like YARN-4865 is also needed

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712021#comment-15712021 ] Eric Payne commented on YARN-4390: -- Hi [~leftnoteasy], I am making an effort to backport

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273108#comment-15273108 ] Wangda Tan commented on YARN-4390: -- Thanks [~jianhe]/[~sunilg]/[~eepayne] for reviewing th

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273017#comment-15273017 ] Hudson commented on YARN-4390: -- FAILURE: Integrated in Hadoop-trunk-Commit #9724 (See [https:

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272503#comment-15272503 ] Eric Payne commented on YARN-4390: -- Sorry, [~leftnoteasy], for the delay. +1. LGTM (+) >

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271149#comment-15271149 ] Jian He commented on YARN-4390: --- patch looks fine to me. > Do surgical preemption based on r

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268687#comment-15268687 ] Sunil G commented on YARN-4390: --- Latest patch looks fine for me.. Thanks [~leftnoteasy]. > D

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267451#comment-15267451 ] Wangda Tan commented on YARN-4390: -- Thanks [~eepayne], [~jianhe], [~sunilg], [~eepayne].

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266555#comment-15266555 ] Eric Payne commented on YARN-4390: -- bq. Long term solution should be fixing YARN-4280. Agr

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265857#comment-15265857 ] Wangda Tan commented on YARN-4390: -- [~eepayne], Yeah you're correct, I think YARN-4280 ca

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264250#comment-15264250 ] Eric Payne commented on YARN-4390: -- [~jlowe] pointed out to me offline that it is probably

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264172#comment-15264172 ] Eric Payne commented on YARN-4390: -- [~leftnoteasy] bq. What's your idea about this case? S

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263339#comment-15263339 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263172#comment-15263172 ] Wangda Tan commented on YARN-4390: -- One question to add: is the 1GB container requested by

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263169#comment-15263169 ] Wangda Tan commented on YARN-4390: -- [~eepayne], What's your idea about this case? Should

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263164#comment-15263164 ] Eric Payne commented on YARN-4390: -- [~leftnoteasy], I am seeing kind of corner case in my

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262733#comment-15262733 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261207#comment-15261207 ] Wangda Tan commented on YARN-4390: -- Oh, I think I understand what happened. If you set nat

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260985#comment-15260985 ] Eric Payne commented on YARN-4390: -- [~leftnoteasy], {quote} have you set following config?

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259398#comment-15259398 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259248#comment-15259248 ] Wangda Tan commented on YARN-4390: -- [~eepayne], I tried this in a SLS cluster: 3 nodes, e

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259151#comment-15259151 ] Wangda Tan commented on YARN-4390: -- Thanks [~eepayne], I will test it locally as well, ha

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258653#comment-15258653 ] Wangda Tan commented on YARN-4390: -- [~kasha], Thanks for comment, There're two different

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258018#comment-15258018 ] Karthik Kambatla commented on YARN-4390: Looked only at the SchedulerNode changes,

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257484#comment-15257484 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257433#comment-15257433 ] Jian He commented on YARN-4390: --- that sounds ok to me. some other comments - why does this n

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257344#comment-15257344 ] Wangda Tan commented on YARN-4390: -- [~jianhe], [~sunilg], For your concerns regarding to p

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257292#comment-15257292 ] Wangda Tan commented on YARN-4390: -- [~sunilg], Thanks for comments: bq. 1. In CapacityS

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257178#comment-15257178 ] Wangda Tan commented on YARN-4390: -- [~jianhe]. Thanks for review: bq. Looks like the app

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256541#comment-15256541 ] Sunil G commented on YARN-4390: --- HI [~leftnoteasy] Thanks for sharing patch here, Few commen

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255109#comment-15255109 ] Hadoop QA commented on YARN-4390: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255050#comment-15255050 ] Jian He commented on YARN-4390: --- some comments after scanning the patch: - Looks like the app

[jira] [Commented] (YARN-4390) Do surgical preemption based on reserved container in CapacityScheduler

[ https://issues.apache.org/jira/browse/YARN-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254859#comment-15254859 ] Wangda Tan commented on YARN-4390: -- Sure, please [~eepayne]. Would really appreciate if yo