[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-09-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604405#comment-16604405 ] Hudson commented on YARN-8638: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #148

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-09-05 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604384#comment-16604384 ] Shane Kumpf commented on YARN-8638: --- I opened HADOOP-15721 and YARN-8748 to discuss disa

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-09-05 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604366#comment-16604366 ] Shane Kumpf commented on YARN-8638: --- Thanks for the contribution, [~ccondit-target] and

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-09-01 Thread Shane Kumpf (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599643#comment-16599643 ] Shane Kumpf commented on YARN-8638: --- Thanks for the patch [~ccondit-target]! I have been

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-29 Thread Kenny Chang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596868#comment-16596868 ] Kenny Chang commented on YARN-8638: --- +1 Noob, non-binding. > Allow linux container runt

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-24 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591801#comment-16591801 ] Eric Badger commented on YARN-8638: --- Thanks for the patch updates, [~ccondit-target]. Pa

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-24 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591735#comment-16591735 ] Craig Condit commented on YARN-8638: [~ebadger] I think I've addressed all your concer

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590876#comment-16590876 ] Craig Condit commented on YARN-8638: Current warnings (shouldn't prevent merging IMO):

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590869#comment-16590869 ] genericqa commented on YARN-8638: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590762#comment-16590762 ] genericqa commented on YARN-8638: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590587#comment-16590587 ] Eric Yang commented on YARN-8638: - [~ccondit-target] Can {@link #STATIC_NON_PRIMITIVE_FIEL

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590572#comment-16590572 ] Jason Lowe commented on YARN-8638: -- bq. However, it also can cause security issues, if co

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590489#comment-16590489 ] Craig Condit commented on YARN-8638: bq. I think this is the correct way to go and is

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590483#comment-16590483 ] Eric Badger commented on YARN-8638: --- bq. LinuxContainerRuntime is already marked @Privat

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590477#comment-16590477 ] Eric Yang commented on YARN-8638: - [~jlowe] {quote} Unless I'm missing something, the whol

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590430#comment-16590430 ] Craig Condit commented on YARN-8638: bq. As I see it, the concern here is whether we'r

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590416#comment-16590416 ] Jason Lowe commented on YARN-8638: -- Unless I'm missing something, the whole point of a pl

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590412#comment-16590412 ] Eric Badger commented on YARN-8638: --- bq. Default's logic is as before, but since pluggab

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590403#comment-16590403 ] Craig Condit commented on YARN-8638: [~ebadger], isRuntimeRequested() was added to all

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590390#comment-16590390 ] Eric Yang commented on YARN-8638: - [~leftnoteasy] The purpose of this JIRA is to swap cont

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Eric Badger (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590376#comment-16590376 ] Eric Badger commented on YARN-8638: --- bq. It will be very clean if we can make runc/conta

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590315#comment-16590315 ] Craig Condit commented on YARN-8638: [~leftnoteasy], I believe runc support (especiall

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-23 Thread Craig Condit (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590307#comment-16590307 ] Craig Condit commented on YARN-8638: [~csingh], the intent with this patch is to be as

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-22 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589478#comment-16589478 ] Wangda Tan commented on YARN-8638: -- [~ccondit-target], Thanks for working on this ticke

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-22 Thread Chandni Singh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589403#comment-16589403 ] Chandni Singh commented on YARN-8638: - [~ccondit-target] The change looks good to me.

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575768#comment-16575768 ] genericqa commented on YARN-8638: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575734#comment-16575734 ] genericqa commented on YARN-8638: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-09 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575602#comment-16575602 ] genericqa commented on YARN-8638: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable

2018-08-08 Thread Allen Wittenauer (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574191#comment-16574191 ] Allen Wittenauer commented on YARN-8638: This sort of exemplifies the misuse of th