Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-29 Thread Yang Shi
On 10/29/2013 5:40 AM, Bruce Ashfield wrote: On 13-10-29 05:28 AM, Hans Beckérus wrote: On Tue, Oct 29, 2013 at 1:38 AM, Khem Raj wrote: On Fri, Oct 25, 2013 at 12:17 PM, Yang Shi wrote: On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will cause build error on MIPS64. C

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-29 Thread Yang Shi
On 10/28/2013 5:38 PM, Khem Raj wrote: On Fri, Oct 25, 2013 at 12:17 PM, Yang Shi wrote: On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will cause build error on MIPS64. Convert __u64 to unsigned long long in those sprintf calls to avoid the build error. Signed-off-by: Ya

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-29 Thread Bruce Ashfield
On 13-10-29 05:28 AM, Hans Beckérus wrote: On Tue, Oct 29, 2013 at 1:38 AM, Khem Raj wrote: On Fri, Oct 25, 2013 at 12:17 PM, Yang Shi wrote: On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will cause build error on MIPS64. Convert __u64 to unsigned long long in those spr

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-29 Thread Hans Beckérus
On Tue, Oct 29, 2013 at 1:38 AM, Khem Raj wrote: > On Fri, Oct 25, 2013 at 12:17 PM, Yang Shi wrote: >> On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will >> cause >> build error on MIPS64. >> >> Convert __u64 to unsigned long long in those sprintf calls to avoid the build

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-28 Thread Khem Raj
On Fri, Oct 25, 2013 at 12:17 PM, Yang Shi wrote: > On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will cause > build error on MIPS64. > > Convert __u64 to unsigned long long in those sprintf calls to avoid the build > error. > > Signed-off-by: Yang Shi > --- > tools/perf/te

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-25 Thread Yang Shi
On 10/25/2013 1:14 PM, Billie Alsup wrote: I guess for that example, you have to add % yourself "%s/event-%d-%" PRIu64 "-%d" but for all the WRITE_ASS examples, simply replace "llu" with PRIu64 Thanks for the suggestion. I had a try, but it failed to build for x86_64. | tests/attr.c:74:4: er

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-25 Thread Billie Alsup
I guess for that example, you have to add % yourself "%s/event-%d-%" PRIu64 "-%d" but for all the WRITE_ASS examples, simply replace "llu" with PRIu64 On 10/25/13 1:11 PM, "Billie Alsup" wrote: >Wouldn't it be better to change "%llu" to PRIu64 (from inttypes.h)? >Notice that PRIu32 is already

Re: [yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-25 Thread Billie Alsup
Wouldn't it be better to change "%llu" to PRIu64 (from inttypes.h)? Notice that PRIu32 is already used in places. You can use string catenation where necessary, e.g. "%s/event-%d-" PRIu64 "-%d" On 10/25/13 12:17 PM, "Yang Shi" wrote: >On MIPS64, "__u64" is "unsigned long" type, so the "%llu" s

[yocto] [PATCH] perf: mips64: Convert __u64 to unsigned long long

2013-10-25 Thread Yang Shi
On MIPS64, "__u64" is "unsigned long" type, so the "%llu" specifier will cause build error on MIPS64. Convert __u64 to unsigned long long in those sprintf calls to avoid the build error. Signed-off-by: Yang Shi --- tools/perf/tests/attr.c | 20 ++-- tools/perf/te