Re: [yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-10 Thread Robert Yang
On 12/09/2017 12:20 AM, Burton, Ross wrote: On 8 December 2017 at 14:07, Alexander Kanavin mailto:alexander.kana...@linux.intel.com>> wrote: On 12/08/2017 03:51 AM, Robert Yang wrote: I'm not sure about this one. Commits shouldn't be created automatically on a pe

Re: [yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-08 Thread Burton, Ross
On 8 December 2017 at 14:07, Alexander Kanavin < alexander.kana...@linux.intel.com> wrote: > On 12/08/2017 03:51 AM, Robert Yang wrote: > > I'm not sure about this one. Commits shouldn't be created automatically on >>> a person's behalf and then also signed-off - I'd say you need to first look >>>

Re: [yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-08 Thread Alexander Kanavin
On 12/08/2017 03:51 AM, Robert Yang wrote: I'm not sure about this one. Commits shouldn't be created automatically on a person's behalf and then also signed-off - I'd say you need to first look at them. IMHO, Auh is a helper, when user run: $ auh less It helps create commits, should be the s

Re: [yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-07 Thread Robert Yang
Hello, On 12/07/2017 09:02 PM, Alexander Kanavin wrote: On 12/07/2017 09:37 AM, Robert Yang wrote: E.g.,: $ upgradehelper.py less commit d9b551438037e105eebabbbcb2da6d8b8cae7504 Author: Robert Yang Date:   Wed Dec 6 16:38:55 2017 +0800 less: upgrade to 529 Signed-off-by: Robert Ya

Re: [yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-07 Thread Alexander Kanavin
On 12/07/2017 09:37 AM, Robert Yang wrote: E.g.,: $ upgradehelper.py less commit d9b551438037e105eebabbbcb2da6d8b8cae7504 Author: Robert Yang Date: Wed Dec 6 16:38:55 2017 +0800 less: upgrade to 529 Signed-off-by: Robert Yang I'm not sure about this one. Commits shouldn't be cr

[yocto] [PATCH 09/12] upgradehelper.py: use git user in commit when recipes are specified

2017-12-06 Thread Robert Yang
E.g.,: $ upgradehelper.py less commit d9b551438037e105eebabbbcb2da6d8b8cae7504 Author: Robert Yang Date: Wed Dec 6 16:38:55 2017 +0800 less: upgrade to 529 Signed-off-by: Robert Yang Signed-off-by: Robert Yang --- upgradehelper.py | 6 +- 1 file changed, 5 insertions(+), 1 del