On Freitag, 2. November 2007, Asheesh Laroia wrote: > On a wiki I maintain, I find that people enter "spam hardened" > (supposedly) email addresses, like asheesh AT creativecommons DOT org. I > figured it would be nice to show those, even if they're not really email > addresses. > > It was easy to comment out the validator, but that's not what this email > is about: I propose (with a patch, attached) that SMW always urlencode() > email addresses when generating their URIs and URLs. > > This is always a safe thing to do, and it may in some cases (as for me) be > a crucial correctness issue. Hopefully you'll apply this.
Good point. I did this now in SVN (and RC2 might come out tomorrow). In fact, I also did something similar to all URLs/URIs. Now we do no longer check for problematic characters in URLs but just encode them. On the other side, the protocol part is now extracted and checked, and only allowed protocols will get linked in the wiki (e.g. "file://" will normally not get linked). Should we also simplify the checks in the case of emails? Note that the string "mailto:john%20doe%20AT%20example.org"; is technically valid as a URL, but does not conform to the mailto-scheme. (Also note that we use rawurlencode() that uses '%20' instead of '+' to encode spaces, as required by RFC 3986 [1].) -- Markus [1] http://www.ietf.org/rfc/rfc3986.txt > > -- Asheesh. > > -- > A penny saved kills your career in government. -- Markus Krötzsch Institut AIFB, Universät Karlsruhe (TH), 76128 Karlsruhe phone +49 (0)721 608 7362 fax +49 (0)721 608 5998 [EMAIL PROTECTED] www http://korrekt.org
pgpZgEUnIWLsY.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ Semediawiki-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
