Hi,

when cleaning up comments, I just stepped over external_mapping.py.

* The input-file is a text file, isn't it? So why is it read in binary mode?

* Leading/trailing spaces in host- and vm-names are preserved is this
intended? Are names allowed to contains spaces at all? If not, i would
change the file and strip leading/trailing white-spaces which would make
the file format more robust.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goe...@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Shinken-devel mailing list
Shinken-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/shinken-devel

Reply via email to