On Nov 7, 2007, at 11:03 AM, svilen wrote:
> > also, i put a > > class ClauseVisitor( sql_util.AbstractClauseProcessor): > def convert_element( me, e): return None > in the beginning of the tests.sql.generative, and after ignoreing this > or that error, here is similar thing: > > ====================================================================== > FAIL: test_correlated_select (__main__.ClauseTest) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "sql/generative.py", line 235, in test_correlated_select > self.assert_compile(Vis().traverse(s, clone=True), "SELECT * FROM > table1 WHERE table1.col1 = table2.col1 AND table1.col2 > = :table1_col2") > File "/home/az/src/ver/sqlalchemy-trunk/test/testlib/testing.py", > line 262, in assert_compile > self.assert_(cc == result, "\n'" + cc + "'\n does not match \n'" + > result + "'") > AssertionError: > 'SELECT * FROM table1 WHERE table1.col1 = table2.col1' > does not match > 'SELECT * FROM table1 WHERE table1.col1 = table2.col1 AND table1.col2 > = :table1_col2' > > here whole subexpr is gone that would be...correct ? replacing convert_element() to return None means the given clause will be copied with no changes. the original clause doesnt have the extra subexpression. > > > > On Wednesday 07 November 2007 17:45:04 svilen wrote: >> On Wednesday 07 November 2007 16:57:08 Michael Bayer wrote: >>> On Nov 7, 2007, at 2:03 AM, [EMAIL PROTECTED] wrote: >>>> - something changed in the traversing (AbstractClauseProcessor >>>> - r3727) >>>> and it does not find proper things... >>> >>> ACP has been entirely rewritten. if you can provide simple >>> tests in the form that theyre present in test/sql/generative.py >>> and/or test/sql/ selectable.py that would be helpful. I have a >>> feeling its not "missing" things, its just doing it slightly >>> differently. >> >> i did print the interesting elements in my >> Converter.convert_element(), and the result is that >> a) order is slightly different - which i dont care >> b) 1 item is not traversed in r3727 >> e.g. >> >> r3626: >>> Column tags.tabl >>> Column tags.oid >>> Column movies.id >>> Column tags.tabl >>> Column tags.oid >>> Column movies.id >>> Column users.id >>> Column userpics.uid >>> Column userpics.state >> >> .... >> >> r3627: >>> Column tags.tabl >>> Column tags.oid >>> Column movies.id >>> Column tags.oid >>> Column movies.id >>> Column users.id >>> Column userpics.uid >>> Column userpics.state >> >> the 2nd tags.tabl is missing, hence the assertFails >> >> ciao >> svilen >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
