On 25/05/11 02:00, Tsachi wrote:
As I understand from the squid.conf documentation login=PASSTHRU:
"Send login details received from client to this peer. Both Proxy- and
WWW-Authorization headers are passed without alteration to the peer."
But as I mentioned in my previous messages proxy-authenticate headers
sent from the proxy are removed before sent to the client (unless
login=PASS is configured).
Is that how the PASSTHRU should behave?
In any case I also set the connection-auth=on for that peer.
Bug. Only the request was handled correctly. The reply was missed out.
Please try the attached patch. It should make PASSTHRU work in both
directions.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE9 or 3.1.12
Beta testers wanted for 3.2.0.7 and 3.1.12.1
=== modified file 'src/client_side_reply.cc'
--- src/client_side_reply.cc 2011-05-09 06:40:03 +0000
+++ src/client_side_reply.cc 2011-05-24 23:13:21 +0000
@@ -1264,9 +1264,9 @@
hdr->delById(HDR_SET_COOKIE);
// TODO: RFC 2965 : Must honour Cache-Control: no-cache="set-cookie2" and remove header.
- // if there is not configured a peer proxy with login=PASS option enabled
+ // if there is not configured a peer proxy with login=PASS or login=PASSTHRU option enabled
// remove the Proxy-Authenticate header
- if ( !(request->peer_login && strcmp(request->peer_login,"PASS") ==0))
+ if ( !request->peer_login || (strcmp(request->peer_login,"PASS") != 0 && strcmp(request->peer_login,"PASSTHRU") != 0))
reply->header.delById(HDR_PROXY_AUTHENTICATE);
reply->header.removeHopByHopEntries();
