On segunda-feira, 16 de dezembro de 2013 22:49:03, Michael Andreen wrote: > Fixes #371 > > Signed-off-by: Michael Andreen <h...@ruin.nu>
While the patch itself is fine, I'm not sure it's actually fixing anything.
Michael, can you confirm that it does fix the problem?
The reason being that we set the "codec for C strings" early in the
initialisation, so
QString(text) == QString::fromUtf8(text)
[though with a different codec implementation and a small performance penalty.
(I need to go fix the different codec problem for Qt 5, now that I've improved
the performance of our UTF-8 codec 2.1x to 3.6x times on average data over
ICU[1])]
[1] https://codereview.qt-project.org/69597
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
