Hi Hans, Given how contentious this has been in the past, perhaps it would be better to goad people like rrs@ into giving you a positive, explicit OK rather than relying on a timeout that may not indicate that your change is good, just that your reviewers are busy.
Warner On Thu, Sep 17, 2015 at 3:39 AM, Hans Petter Selasky <h...@selasky.org> wrote: > On 09/17/15 11:07, David Chisnall wrote: > >> On 17 Sep 2015, at 08:20, Hans Petter Selasky <h...@selasky.org> wrote: >> >>> >>> On 09/17/15 00:05, Gleb Smirnoff wrote: >>> >>>> Weren't you explicitly asked not to touch this system without a proper >>>> review and discussion? >>>> >>> >>> Adding a new function is not touching code. >>> >> >> Adding a new interface to an existing core subsystem is most definitely >> touching the system. I would expect *anyone* making a change like this to >> have both the design and code reviewed for sanity checking. >> > > For someone who has already been required to have explicit review of any > changes to the subsystem to skip this step shows a flagrant disregard for > the project’s policies and best practices. > > David, > > My patch is _not_ touching the existing callout system. It's touching the > callout API. Maybe my understanding of touching is different than yours. > You can voice your conserns in phabricator please, isn't that why we have > Phabricator? > > https://reviews.freebsd.org/D3521 > > The differential review has been out for 14 days with relevant people like > rss on the reviewers list, and no conserns were raised. Only manual page > comments from wblock, and those were addressed. I will refer to a well > known saying, that whoever tier agree. It is a bit late to shout now. > > David, I think phabricator allows filtering so that all commits which > touch sys/kern gets your subscription. At least wblock was automatically > subscribed because of updating some manual pages. I think that's the way to > go. > > Let's end this discussion here and move it somewhere else. > > --HPS > > > _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
