On Tue, Apr 5, 2011 at 8:37 AM, Vinzent Steinberg <vinzent.steinb...@googlemail.com> wrote: > On 4 Apr., 22:26, Ondrej Certik <ond...@certik.cz> wrote: >> The pull requests should be used only for code, that the author thinks >> is *ready* to go in. So people will comment, and more work will be >> needed. That is ok, it will take a day or two, to polish this up. If >> it takes 3 weeks however, then I think the code is clearly not ready >> to go in, and the pull request should be closed (no code/comments are >> lost by closing it). > > I'm a bit concerned about this. If there is a new pull request, the > old comments are somewhat hard to find, compared to a single pull > request.
I think the suggestion is to not open a new one but to reopen the same one. Aaron Meurer > > Aaron wrote: >> I suppose this is ok, AS LONG AS we also have an issue for the pull, which >> will stay open (so we don't forget about the issue entirely). > > +1 > > Vinzent > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sympy@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
