Hi
On Wed, Sep 10, 2014 at 11:20 AM, <philippedesw...@gmail.com> wrote:
> From: Philippe De Swert <philippedesw...@gmail.com>
>
> Actually unref the buscreds when we are not going to return a
> pointer to them. As when bus_creds_add_more fails we immediately
> return the error code otherwise and leak the new buscreds.
> Found with coverity. Fixes: CID#1237761
>
> Signed-off-by: Philippe De Swert <philippedesw...@gmail.com>
Applied!
Thanks
David
> ---
> src/libsystemd/sd-bus/sd-bus.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c
> index 78e91b9..83b3aa1 100644
> --- a/src/libsystemd/sd-bus/sd-bus.c
> +++ b/src/libsystemd/sd-bus/sd-bus.c
> @@ -3339,8 +3339,10 @@ _public_ int sd_bus_get_peer_creds(sd_bus *bus,
> uint64_t mask, sd_bus_creds **re
> }
>
> r = bus_creds_add_more(c, mask, pid, 0);
> - if (r < 0)
> + if (r < 0) {
> + sd_bus_creds_unref(c);
> return r;
> + }
>
> *ret = c;
> return 0;
> --
> 1.8.3.2
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
