Hi Thomas, On 16/09/14 08:56, Thomas H.P. Andersen wrote: >> Yesterday I finally got to revive the systemd Coverity project on >> scan.coverity.org Unfortunately to see the errors reported you need >> to sign up, but I will make sure to approve requests for seeing the >> "bugs" whenever they show up. > > Hi Philippe, > > I was wondering if it is possible to enable selinux for the scans? We > have a lot of reports of "Logically dead code". They are mostly due to > selinux_unit_access_check() being defined as > #define selinux_unit_access_check(unit, message, permission, error) 0 > when HAVE_SELINUX is not set. See e.g. CID#1237573 > > I can of course just mark them as false positive but it would be > better to have those code paths covered as well.
Actually I was just looking at them and wondering about the same ;) You're email saved me from looking at the code to figure out why things are defined as such. Will make a build with selinux and upload sometime today. Cheers, Philippe _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
