Author: rahul Date: Sun Jan 11 17:15:56 2009 New Revision: 733566 URL: http://svn.apache.org/viewvc?rev=733566&view=rev Log: Minor code cleanup in the oat.rdc package - remove Javadoc warnings, unused variables, add serialVersionUIDs, some sorting of import statements and the like.
Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alpha.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alphanum.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Color.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Country.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardAmount.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardData.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardExpiry.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardInfo.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardNumber.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardType.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Currency.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Date.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRange.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRangeData.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Digits.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Duration.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/GrammarServlet.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/HelloWorldBean.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ISBN.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Mortgage.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageData.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageType.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Number.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Pause.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Percent.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/RDCUtils.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SelectOne.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SocialSecurityNumber.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Time.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USMajorCity.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USState.java jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ZipCode.java Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alpha.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alpha.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alpha.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alpha.java Sun Jan 11 17:15:56 2009 @@ -32,11 +32,13 @@ */ public class Alpha extends BaseModel { - // The alpha RDC will be associated with the alphabetical + // The alpha RDC will be associated with the alphabetical // input (spelling), the maximum and minimum length within // which the input's length must lie, and a pattern to which // the input must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // Maximum allowed length of the input; -1 indicates // no constraint on maximum length private int minLength; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alphanum.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alphanum.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alphanum.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Alphanum.java Sun Jan 11 17:15:56 2009 @@ -36,6 +36,8 @@ // input's length must lie, and a pattern to which the input // must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // Maximum allowed length of the input; -1 indicates // no constraint on maximum length private int minLength; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Color.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Color.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Color.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Color.java Sun Jan 11 17:15:56 2009 @@ -28,6 +28,8 @@ */ public class Color extends BaseModel { + private static final long serialVersionUID = 1L; + /** * Sets default values for all data members */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Country.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Country.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Country.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Country.java Sun Jan 11 17:15:56 2009 @@ -28,6 +28,8 @@ public class Country extends BaseModel { + private static final long serialVersionUID = 1L; + /** * Sets default values for all data members */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardAmount.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardAmount.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardAmount.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardAmount.java Sun Jan 11 17:15:56 2009 @@ -43,6 +43,8 @@ // part and nn is the fractional part. If currency code is not // specified the default currency code for the default locale is used. + // Serial Version UID + private static final long serialVersionUID = 1L; // Maximum allowed amount for this payment private String maxAmount; // Minimum allowed amount for this payment @@ -218,8 +220,9 @@ * code UUU is ignored and the default currency code or * the supplied currency code is assumed. * - * @param strInput The maximum or minimum amount, - * either in UUUmm.nn or mm.nn format + * @param input The maximum or minimum amount, + * either in UUUmm.nn or mm.nn format + * @param isAttribute Whether the input is passed via a tag attribute * @return formatted maximum or minimum value in mm.nn format */ protected Object canonicalize(Object input, boolean isAttribute) { Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardData.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardData.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardData.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardData.java Sun Jan 11 17:15:56 2009 @@ -27,6 +27,8 @@ */ public class CreditCardData implements Serializable { + // Serial Version UID + private static final long serialVersionUID = 1L; // Properties, one for each child component private String type; private String number; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardExpiry.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardExpiry.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardExpiry.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardExpiry.java Sun Jan 11 17:15:56 2009 @@ -31,6 +31,8 @@ */ public class CreditCardExpiry extends BaseModel { + // Serial Version UID + private static final long serialVersionUID = 1L; // Error codes, corresponding prompts defined in configuration file /**A constant for Error Code stating card has already expired * (as of today) */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardInfo.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardInfo.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardInfo.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardInfo.java Sun Jan 11 17:15:56 2009 @@ -26,6 +26,8 @@ */ public class CreditCardInfo extends ComponentModel { + // Serial Version UID + private static final long serialVersionUID = 1L; // The mode this instance will work in private String mode; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardNumber.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardNumber.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardNumber.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardNumber.java Sun Jan 11 17:15:56 2009 @@ -25,7 +25,10 @@ * @author Rahul Akolkar */ public class CreditCardNumber extends BaseModel { - + + // Serial Version UID + private static final long serialVersionUID = 1L; + // Maximum number of denials before a graceful exit private int maxDenials; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardType.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardType.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardType.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/CreditCardType.java Sun Jan 11 17:15:56 2009 @@ -27,6 +27,9 @@ public class CreditCardType extends BaseModel { + // Serial Version UID + private static final long serialVersionUID = 1L; + /** * Sets default values for all data members */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Currency.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Currency.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Currency.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Currency.java Sun Jan 11 17:15:56 2009 @@ -46,6 +46,8 @@ // part and nn is the fractional part. If currency code is not // specified the default currency code for the default locale is assumed. + // Serial Version UID + private static final long serialVersionUID = 1L; // Maximum allowed value for the amount private String maxValue; // Minimum allowed value for the amount @@ -158,7 +160,8 @@ * is in UUUmm.nn format the currency code UUU is ignored and the default currency code or * the supplied currency code is assumed. * - * @param strInput The maximum or minimum amount, either in UUUmm.nn or mm.nn format + * @param input The maximum or minimum amount, either in UUUmm.nn or mm.nn format + * @param isAttribute Whether the input is passed via a tag attribute * @return formatted maximum or minimum value in mm.nn format */ protected Object canonicalize(Object input, boolean isAttribute) { Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Date.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Date.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Date.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Date.java Sun Jan 11 17:15:56 2009 @@ -38,6 +38,8 @@ // minimum dates within which the date input must lie, and a date format to // which the date input must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // Date returned must conform to this format private String format; // Date returned cannot be beyond this date @@ -149,7 +151,8 @@ * Sets up the date string, converting phrases of today and tomorrow * into valid dates followed by the format filter * - * @param strInput The date input string + * @param input The date input string + * @param isAttribute Whether the input is passed via a tag attribute * @return The value of date (conforming to format) */ protected Object canonicalize(Object input, boolean isAttribute) { Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRange.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRange.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRange.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRange.java Sun Jan 11 17:15:56 2009 @@ -26,6 +26,10 @@ */ public class DateRange extends ComponentModel { + + // Serial Version UID + private static final long serialVersionUID = 1L; + public DateRange() { super(); Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRangeData.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRangeData.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRangeData.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/DateRangeData.java Sun Jan 11 17:15:56 2009 @@ -24,6 +24,8 @@ */ public class DateRangeData implements Serializable { + // Serial Version UID + private static final long serialVersionUID = 1L; // Start and end dates private String startDate; private String endDate; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Digits.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Digits.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Digits.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Digits.java Sun Jan 11 17:15:56 2009 @@ -37,6 +37,8 @@ // which the input's length must lie, and a pattern to which // the input must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // Maximum allowed length of the input; -1 indicates // no constraint on maximum length private int minLength; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Duration.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Duration.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Duration.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Duration.java Sun Jan 11 17:15:56 2009 @@ -36,6 +36,8 @@ //duration within which the input's duration must lie, and a pattern to //which the input must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // value returned cannot be more than this value private String maxDuration; // value returned cannot be less than this value Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/GrammarServlet.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/GrammarServlet.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/GrammarServlet.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/GrammarServlet.java Sun Jan 11 17:15:56 2009 @@ -42,6 +42,9 @@ extends HttpServlet { //// Constants + // Serial Version UID + private static final long serialVersionUID = 1L; + // Init params and default values private static final String INIT_PARAM_GRAM_DIR = "grammarDirectory"; private static final String DEFAULT_GRAM_DIR = ".grammar"; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/HelloWorldBean.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/HelloWorldBean.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/HelloWorldBean.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/HelloWorldBean.java Sun Jan 11 17:15:56 2009 @@ -20,6 +20,7 @@ /** HelloWorldBean */ public class HelloWorldBean implements Serializable { + private static final long serialVersionUID = 1L; String name; /** Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ISBN.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ISBN.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ISBN.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ISBN.java Sun Jan 11 17:15:56 2009 @@ -37,6 +37,8 @@ // ISBN is a 10 digit // number and should conform to this length. + // Serial Version UID + private static final long serialVersionUID = 1L; // The ISBN input must conform to this pattern private String pattern; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Mortgage.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Mortgage.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Mortgage.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Mortgage.java Sun Jan 11 17:15:56 2009 @@ -27,6 +27,9 @@ */ public class Mortgage extends ComponentModel { + // Serial Version UID + private static final long serialVersionUID = 1L; + public Mortgage(){ super(); } Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageData.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageData.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageData.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageData.java Sun Jan 11 17:15:56 2009 @@ -26,6 +26,7 @@ public class MortgageData implements Serializable { + private static final long serialVersionUID = 1L; private String percent; private String mortgageType; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageType.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageType.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageType.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/MortgageType.java Sun Jan 11 17:15:56 2009 @@ -29,7 +29,8 @@ public class MortgageType extends BaseModel { - + // Serial Version UID + private static final long serialVersionUID = 1L; // value returned cannot be less than this value private String minTerm; // value returned cannot be more than this value Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Number.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Number.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Number.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Number.java Sun Jan 11 17:15:56 2009 @@ -36,6 +36,9 @@ // The value returned by the grammar is fixed-number representation // and initial must conform to that. + // Serial Version UID + private static final long serialVersionUID = 1L; + // Maximum allowed value of the input; null value indicates // no constraint on maximum value private Double minValue; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Pause.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Pause.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Pause.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Pause.java Sun Jan 11 17:15:56 2009 @@ -26,6 +26,9 @@ */ public class Pause extends BaseModel { + // Serial Version UID + private static final long serialVersionUID = 1L; + // The URI where the application will resume after being "unpaused" private String resumeURI; @@ -49,7 +52,7 @@ /** * Set the URI where the application will resume after being "unpaused" * - * @param String the resumeURI + * @param string The resumeURI */ public void setResumeURI(String string) { this.resumeURI = string; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Percent.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Percent.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Percent.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Percent.java Sun Jan 11 17:15:56 2009 @@ -36,7 +36,9 @@ // the maximum and minimum values within which the input must // lie . - //this is the pattern for percent + // Serial Version UID + private static final long serialVersionUID = 1L; + // This is the pattern for percent private String pattern; // Maximum allowed value for the percentage private int maxPercent; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/RDCUtils.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/RDCUtils.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/RDCUtils.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/RDCUtils.java Sun Jan 11 17:15:56 2009 @@ -17,9 +17,7 @@ package org.apache.taglibs.rdc; import java.io.IOException; -import java.lang.NoSuchMethodException; import java.lang.reflect.Field; -import java.lang.reflect.Method; import java.net.URI; import java.net.URISyntaxException; import java.text.MessageFormat; @@ -29,7 +27,6 @@ import java.util.zip.ZipEntry; import javax.servlet.jsp.PageContext; - import javax.xml.parsers.DocumentBuilder; import javax.xml.parsers.DocumentBuilderFactory; import javax.xml.transform.TransformerException; @@ -40,13 +37,12 @@ import org.apache.taglibs.rdc.core.ComponentModel; import org.apache.taglibs.rdc.core.Constants; import org.apache.taglibs.rdc.core.GroupModel; - import org.apache.xpath.XPathAPI; import org.apache.xpath.objects.XObject; -import org.xml.sax.InputSource; import org.w3c.dom.Document; import org.w3c.dom.Node; import org.w3c.dom.NodeList; +import org.xml.sax.InputSource; /** * Utility methods for the rdc package @@ -83,8 +79,8 @@ /** * Return true if the given class implements the given interface. * - * @param Class clas - * @param Class interfayce + * @param clas The candidate class + * @param interfayce The given interface */ public static boolean implementsInterface(Class clas, Class interfayce) { while (clas != null && clas != Object.class) { @@ -103,8 +99,8 @@ /** * Return true if the given class defines or inherits the given field. * - * @param Class clas - * @param String field + * @param clas The candidate class + * @param field The given field */ public static boolean hasField(Class clas, String field) { while (clas != null && clas != Object.class) { @@ -123,15 +119,15 @@ /** * Return true if the given class defines or inherits the given method. * - * @param Class clas - * @param String method + * @param clas The candidate class + * @param methodName The name of the given method + * @param paramTypes The array of parameter types the method accepts */ public static boolean hasMethod(Class clas, String methodName, Class[] paramTypes) { while (clas != null && clas != Object.class) { - Method method = null; try { - method = clas.getDeclaredMethod(methodName, paramTypes); + clas.getDeclaredMethod(methodName, paramTypes); } catch (NoSuchMethodException nsme) { clas = clas.getSuperclass(); continue; @@ -145,7 +141,7 @@ * Return the Class for this class name, if such a class exists, * else return null. * - * @param String className + * @param className The class name */ public static Class getClass(String className) { try { @@ -161,8 +157,8 @@ /** * Log error if the supplied string is null or empty. * - * @param String str - * @param String err_msg + * @param str The supplied string + * @param err_msg The error message to log if null or empty */ public static void mustExist(String str, String err_msg) { if (str == null || str.trim().length() == 0) { @@ -173,8 +169,8 @@ /** * Log error if the supplied condition is not satisfied. * - * @param boolean cond - * @param String err_msg + * @param cond The test condition + * @param err_msg The error message to log if test fails */ public static void mustSatisfy(boolean cond, String err_msg) { if (!cond) { @@ -185,8 +181,8 @@ /** * Print warning via if the supplied error condition holds, but move on. * - * @param boolean cond - * @param String err_msg + * @param cond The test condition + * @param err_msg The warning message to log if test fails */ public static void warnIf(boolean cond, String err_msg) { if (cond) { @@ -197,7 +193,7 @@ /** * Return true if this string contains non-white space characters. * - * @param String str + * @param str The candidate string */ public static boolean isStringEmpty(String str) { if (str == null || str.trim().length() == 0) { Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SelectOne.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SelectOne.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SelectOne.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SelectOne.java Sun Jan 11 17:15:56 2009 @@ -33,6 +33,8 @@ // The SelectOne RDC will be associated with the list input. From // a list of options the user selects one option + // Serial Version UID + private static final long serialVersionUID = 1L; // The optionList attribute private Object optionList; // The list of available options for selection @@ -86,7 +88,7 @@ * Sets the Options object. This contains all the options from which * the user selects a value. * - * @param Options + * @param optionList The list of options */ public void setOptionList(Object optionList) { this.optionList = optionList; @@ -112,7 +114,7 @@ /** * Set the class name of the options for this instance * - * @param String class name as a String + * @param string The class name as a string */ public void setOptionsClass(String string) { optionsClass = string; @@ -125,6 +127,9 @@ */ public static class Options implements Serializable { + // Serial Version UID + private static final long serialVersionUID = 1L; + // "accept" attribute values public static final String ACCEPT_EXACT = "exact"; public static final String ACCEPT_APPROX = "approximate"; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SocialSecurityNumber.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SocialSecurityNumber.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SocialSecurityNumber.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/SocialSecurityNumber.java Sun Jan 11 17:15:56 2009 @@ -36,6 +36,9 @@ // input and a pattern to which the input must conform. The ssn is a 9 digit // number and should conform to this length. + // Serial Version UID + private static final long serialVersionUID = 1L; + // The social security number input must conform to this pattern private String pattern; Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Time.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Time.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Time.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/Time.java Sun Jan 11 17:15:56 2009 @@ -38,6 +38,8 @@ // and the maximum and minimum times within which the // time input must lie. + // Serial Version UID + private static final long serialVersionUID = 1L; // Time returned cannot be before this time private java.util.Date minTime; // Time returned cannot be beyond this time @@ -134,8 +136,8 @@ /** * Converts the min and max time strings to java.util.Date objects * - * @param str the time string to be converted (hhmma) - * + * @param input The time string to be converted (hhmma) + * @param isAttribute Whether the input is passed via a tag attribute * @return The java.util.Date object for the time string */ protected Object canonicalize(Object input, boolean isAttribute) { Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USMajorCity.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USMajorCity.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USMajorCity.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USMajorCity.java Sun Jan 11 17:15:56 2009 @@ -30,6 +30,9 @@ // The usMajorCity RDC is associated with the US major // city input. + // Serial Version UID + private static final long serialVersionUID = 1L; + /** * Sets default values for all data members */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USState.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USState.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USState.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/USState.java Sun Jan 11 17:15:56 2009 @@ -30,6 +30,9 @@ // The usState RDC is associated with the US state // input. + // Serial Version UID + private static final long serialVersionUID = 1L; + /** * Sets default values for all data members */ Modified: jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ZipCode.java URL: http://svn.apache.org/viewvc/jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ZipCode.java?rev=733566&r1=733565&r2=733566&view=diff ============================================================================== --- jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ZipCode.java (original) +++ jakarta/taglibs/proper/rdc/trunk/taglibs-rdc/src/main/java/org/apache/taglibs/rdc/ZipCode.java Sun Jan 11 17:15:56 2009 @@ -36,6 +36,8 @@ // inputs should have, and a pattern to which the input // must conform. + // Serial Version UID + private static final long serialVersionUID = 1L; // Length of the input; -1 indicates no constraint on length. private int length; // The zip code input must conform to this pattern --------------------------------------------------------------------- To unsubscribe, e-mail: taglibs-dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: taglibs-dev-h...@jakarta.apache.org