#19872: Introduce prefixed sign/verify functions -------------------------------------------------+------------------------- Reporter: asn | Owner: asn Type: task | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.2.9.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: 029-proposed, tor-hs, | Actual Points: 0.3 TorCoreTeam201608 | Parent ID: | Points: 0.3 Reviewer: dgoulet | Sponsor: | SponsorR-can -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_revision => needs_review Comment: Replying to [comment:8 nickm]: > The duplicate code in these two functions should be extracted into a static function. > > The test code should verify not only that "checksig" is the counterpart of "sign", but that "sign" produces the same output as if you had manually prefixed and signed the string. > > `make check-spaces` fails. Great points. Addressed all the above and pushed a new branch as `bug19872_v2`. Please check it out. Thanks! -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19872#comment:11> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs