#19043: prop224: Implementation of ESTABLISH_INTRO cell -------------------------------------------------+------------------------- Reporter: alec.heif | Owner: asn Type: enhancement | Status: | needs_review Priority: Medium | Milestone: Tor: | 0.3.0.x-final Component: Core Tor/Tor | Version: Severity: Normal | Resolution: Keywords: tor-hs, prop224, 6.s194, | Actual Points: TorCoreTeam201610 | Parent ID: #17241 | Points: 3 Reviewer: asn, dgoulet | Sponsor: | SponsorR-must -------------------------------------------------+------------------------- Changes (by asn):
* status: needs_revision => needs_review Comment: Replying to [comment:28 dgoulet]: > Ok I've done a round of review on the merge request. Thanks for the review. I addressed most of your comments and pushed a fixup branch at `bug19043_v2_dgoulet_review`. I also replied to the gitlab comments. This is just a ticket for you to review the fixes. Let me know when you feel OK with them and I can squash all the fixup commits back to the original commit structure. Also, please let me know if you'd like to get the code mutex for now to do miscellaneous improvements (e.g. try out the hs_cells API). Personally, I found it useful when I took the HSDir code from you at the very end, so maybe you also find it useful. Putting this in `needs_review` again for now. -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19043#comment:30> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs