#20147: [PATCH] (re-)dzip.sh: various improvements --------------------------------------+-------------------------------- Reporter: rustybird | Owner: tbb-team Type: enhancement | Status: needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: tbb-gitian | Actual Points: Parent ID: | Points: Reviewer: | Sponsor: --------------------------------------+-------------------------------- Changes (by gk):
* keywords: tbb-gitian, TorBrowserTeam201612R => tbb-gitian * status: needs_review => needs_revision Comment: Sorry for the long time before I got to your patch. Overall it looks good to me. It seems you are using a bunch of bashisms. This is fine with me n general but please don't declare this as a script for the Bourne shell then (which we/you do with `#!/bin/sh`). -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20147#comment:8> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs