#23483: Donation banner on about:tor page for 2017 campaign ------------------------------------------------+-------------------------- Reporter: arthuredelstein | Owner: tbb-team Type: defect | Status: | needs_revision Priority: Medium | Milestone: Component: Applications/Tor Browser | Version: Severity: Normal | Resolution: Keywords: crowdfunding, TorBrowserTeam201709 | Actual Points: Parent ID: #23482 | Points: Reviewer: | Sponsor: ------------------------------------------------+-------------------------- Changes (by gk):
* keywords: crowdfunding, TorBrowserTeam201709R => crowdfunding, TorBrowserTeam201709 * status: needs_review => needs_revision Comment: Looks mostly good. Some nits: 1) `bestSize` and `bestPadding` are not declared in donation_banner.js. (seems I missed that last year ;) ) 2) {{{ +// Increase padding at right to "squeeze" text, until it gets +// squeezed so much that it gets longer vertically. }}} is not correct as is in the case of RTL bundles the padding to the left increased. Could you reflect that in the comment? In the commit message: "Bug 23483." -> "Bug 23483:" -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23483#comment:4> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs