#18320: Clear old entries from the key-pinning journal file -------------------------------------------------+------------------------- Reporter: teor | Owner: andrea Type: defect | Status: Priority: Medium | needs_information Component: Core Tor/Tor | Milestone: Tor: Severity: Normal | 0.2.9.x-final Keywords: tor-dos, TorCoreTeam201607, review- | Version: group-3 | Resolution: Parent ID: #17293 | Actual Points: Reviewer: dgoulet | Points: 3 | Sponsor: | SponsorU-can -------------------------------------------------+-------------------------
Comment (by andrea): > ...returns 0 then setting the ent pointer to NULL. You mean this in {{{keypin_add_line_to_pruner()}}}, where ent is a param and not the same as the one we're calling {{{keypin_add_or_replace_entry_in_map()}}} on back in {{{keypin_load_journal_impl()}}}? I don't think this is actually a bug, unless you had something else in mind. {{{ 457 if (r == 0) { 458 /* 459 * This was a duplicate; we just freed it and won't be adding 460 * anything to the list, but should bump the duplicate counter. 461 */ 462 adding = 0; 463 ent = NULL; 464 ++(p->nlines_pruned_duplicate); }}} -- Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18320#comment:29> Tor Bug Tracker & Wiki <https://trac.torproject.org/> The Tor Project: anonymity online _______________________________________________ tor-bugs mailing list tor-bugs@lists.torproject.org https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs