> -----Original Message----- > From: Jarkko Sakkinen [mailto:[email protected]] > Sent: Monday, September 12, 2016 16:32 > To: Winkler, Tomas <[email protected]> > Cc: [email protected]; Jason Gunthorpe > <[email protected]> > Subject: Re: [PATCH v2 1/4] tpm/tpm_crb: implement tpm crb idle state > > On Mon, Sep 12, 2016 at 03:01:09PM +0300, Jarkko Sakkinen wrote: > > Could you also put this into [email protected]? > > > > On Mon, Sep 12, 2016 at 11:54:58AM +0300, Tomas Winkler wrote: > > > The register TPM_CRB_CTRL_REQ_x contains bits goIdle and cmdReady > > > for SW to indicate that the device can enter or should exit the idle > > > state. > > > > > > The legacy ACPI-start (SMI + DMA) based devices do not support these > > > bits and the idle state management is not exposed to the host SW. > > > Thus, this functionality only is enabled only for a CRB start (MMIO) > > > based devices. > > > > > > Based on Jarkko Sakkinen <[email protected]> oringal > > > patch: > > > 'tpm_crb: implement power tpm crb power management' > > > > > > Signed-off-by: Tomas Winkler <[email protected]> > > > --- > > > V2: do not export the functions via tpm ops > > > > I'm not sure about this. Even if callbacks are there tpm_crb and other > > device drivers can use runtime PM internally (if they want). > > I give this some rethought. Using runtime PM is fine.
Appreciated. Thanks Tomas ------------------------------------------------------------------------------ _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
