On Wed, Oct 26, 2016 at 10:05:05AM -0600, Jason Gunthorpe wrote: > On Wed, Oct 26, 2016 at 01:55:27PM +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 25, 2016 at 05:23:31PM -0600, Jason Gunthorpe wrote: > > > This provides an open firwmare driver binding for tpm_tis. OF > > > is useful on arches where ACPI/PNP is not used. > > > > > > The tcg,tpm_tis-mmio register map interface is specified by the TCG. > > > > > > Signed-off-by: Jason Gunthorpe <[email protected]> > > > .../bindings/security/tpm/tpm_tis_mmio.txt | 22 > > > ++++++++++++++++++++++ > > > > I'll do a proper review later on but should this change be a separate > > commit or not? > > I've understood it is OK for tiny source patches, large ones should be > split. In either case they both go through your tree together. The DT > mailing list just does not want to be spammed...
In general we ask that binding modifications are in a separate patch, earlier in the series (see [1]), but in cases where the additions are small, we're not too bothered. As for why, it's about making it easier to spot the parts we need to act on. We still would like to see the entire series (and ask that we're cc'd [1]), as this can be useful context for review, and there are often mismatches between the documented binding and code that we may spot. Thanks, Mark. [1] Documentation/devicetree/bindings/submitting-patches.txt ------------------------------------------------------------------------------ The Command Line: Reinvented for Modern Developers Did the resurgence of CLI tooling catch you by surprise? Reconnect with the command line and become more productive. Learn the new .NET and ASP.NET CLI. Get your free copy! http://sdm.link/telerik _______________________________________________ tpmdd-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tpmdd-devel
