Hi.  I have noticed that there doesn't seem to be a way to remove
definitions (policy sets etc) from the domain.  The specs don't explicitly
say how this would happen, but surely this can't be a one-way process (you
can add but can't delete).  I can only guess that if definitions are added
as part of a contribution, then those definitions should be removed when the
contribution is removed?  There are some interesting issues, like what if
there are other contributions using elements of those definitions.

As an aside, I've noticed that SCADefinitionsImpl doesn't synchronize the
lists of policy sets, intents, etc. that it keeps, so it is exposed to bad
things happening if multiple threads try to add definitions at the same
time.  SCADefinitionsUtil also does clear/addAll operations that need to be
made thread-safe.

Greg

Reply via email to