On Wednesday 06 May 2009 14:19:07 Scott Wood wrote: > Mike Frysinger wrote: > >>> +/* #define CONFIG_NAND_PLAT */ > >> > >> Why is this commented out? > > > > because it's a driver for an optional add-on card that people usually > > dont have, let alone plugged in > > OK, was hoping there would be at least one config that selects it so it > gets compilation exposure.
i have another board that does rely on it that i'll be merging in the next cycle > >>> +#define NAND_PLAT_DEV_READY(chip) ((*pPORTFIO & BFIN_NAND_READY) > >>> ? 1 : 0) > >> > >> Why not just (*pPORTFIO & BFIN_NAND_READY)? > > > > i thought the nand/mtd layers expect 1/0 only ? if the higher layers > > dont care, then there's no reason. > > A quick grep doesn't show any non-boolean uses. sounds good, i'll make the change then -mike _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot